Changeset 8568

Timestamp:

May 24, 2011, 10:41:43 PM (13 years ago)

Author:

dafrick

Message:

Renaming member variables to adhere to styleguide, initialize values, always select an item in the DockingDialog.

Location:

code/branches/presentation

Files:

• data/gui/scripts/DockingDialog.lua (modified) (1 diff)
• src/modules/docking/DockToShip.cc (modified) (2 diffs)
• src/modules/docking/DockToShip.h (modified) (1 diff)
• src/modules/docking/DockingAnimation.cc (modified) (1 diff)
• src/modules/docking/DockingAnimation.h (modified) (1 diff)
• src/modules/docking/DockingController.cc (modified) (5 diffs)
• src/modules/docking/DockingController.h (modified) (2 diffs)
• src/modules/docking/DockingEffect.cc (modified) (1 diff)
• src/modules/docking/DockingTarget.cc (modified) (1 diff)
• src/modules/docking/DockingTarget.h (modified) (1 diff)
• src/modules/docking/MoveToDockingTarget.cc (modified) (2 diffs)

code/branches/presentation/data/gui/scripts/DockingDialog.lua

@@ -44 +44 @@
         item:setSelectionBrushImage(menuImageSet, "MultiListSelectionBrush")
         listbox:addItem(item)
+        if k == 1 then
+            listbox:setItemSelectState(item, true)
+        end
     end
 end

code/branches/presentation/src/modules/docking/DockToShip.cc

@@ -59 +59 @@
 
     void DockToShip::setTargetId(const std::string& str) {
-        this->target = str;
+        this->target_ = str;
     }
 
     const std::string& DockToShip::getTargetId() const {
-        return this->target;
+        return this->target_;
     }
 
@@ -71 +71 @@
         COUT(4) << "DockToShip::attach" << endl;
 
-        DockingTarget *target = DockingEffect::findTarget(this->target);
+        DockingTarget *target = DockingEffect::findTarget(this->target_);
         if (target == NULL) {
-            COUT(0) << "Can't retrieve target for '" << this->target << "'.." << std::endl;
+            COUT(0) << "Can't retrieve target for '" << this->target_ << "'.." << std::endl;
             return false;
         }

code/branches/presentation/src/modules/docking/DockToShip.h

@@ -67 +67 @@
             virtual bool release(PlayerInfo* player); //!< Called when player wants undock
         private:
-            std::string target;
+            std::string target_;
     };
 

code/branches/presentation/src/modules/docking/DockingAnimation.cc

@@ -41 +41 @@
     {
         RegisterObject(DockingAnimation);
+
+        this->parent_ = NULL;
     }
 

code/branches/presentation/src/modules/docking/DockingAnimation.h

@@ -73 +73 @@
             static DockingTarget *findTarget(std::string name); //!< Iterates through all DockingTarget objects to find the one with name=target
 
-            void setParent(Dock *parent) { this->parent = parent; }
+            void setParent(Dock *parent) { this->parent_ = parent; }
 
         protected:
-            Dock *parent;
-            std::set<PlayerInfo*> animations; //!< Contains a list of currently running animations
+            Dock *parent_;
+            std::set<PlayerInfo*> animations_; //!< Contains a list of currently running animations
     };
 

code/branches/presentation/src/modules/docking/DockingController.cc

@@ -42 +42 @@
     {
         RegisterObject(DockingController);
+
+        this->dock_ = NULL;
+        this->player_ = NULL;
+        this->entity_ = NULL;
     }
 
@@ -55 +59 @@
             return;
 
-        float distance = (dock->getWorldPosition() - entity->getPosition()).length();
+        float distance = (this->dock_->getWorldPosition() - entity->getPosition()).length();
         Vector2 coord = get2DViewdirection(     // I don't understand this too
             entity->getPosition(),
             entity->getOrientation() * WorldEntity::FRONT,
             entity->getOrientation() * WorldEntity::UP,
-            dock->getWorldPosition()
+            dock_->getWorldPosition()
         );
 
@@ -86 +90 @@
     void DockingController::takeControl(bool docking)
     {
-        this->docking = docking;
+        this->docking_ = docking;
 
-        entity = player->getControllableEntity();
-        assert(entity);
+        this->entity_ = this->player_->getControllableEntity();
+        assert(this->entity_);
 
         if (docking)
@@ -95 +99 @@
             COUT(4) << "DockingController::takeControl Taking over control." << std::endl;
 
-            entity->setDestroyWhenPlayerLeft(false);
-            player->pauseControl();
-            entity->setController(this);
-            this->setControllableEntity(entity);
+            this->entity_->setDestroyWhenPlayerLeft(false);
+            this->player_->pauseControl();
+            this->entity_->setController(this);
+            this->setControllableEntity(this->entity_);
         }
     }
@@ -106 +110 @@
         COUT(4) << "DockingController::positionReached() called." << std::endl;
 
-        assert(this->player);
-        assert(this->dock);
+        assert(this->player_);
+        assert(this->dock_);
 
         // stop spaceship
-        entity->setPosition(dock->getWorldPosition());
-        entity->setVelocity(0, 0, 0);
-        entity->setOrientation(dock->getWorldOrientation());
+        this->entity_->setPosition(this->dock_->getWorldPosition());
+        this->entity_->setVelocity(0, 0, 0);
+        this->entity_->setOrientation(this->dock_->getWorldOrientation());
 
         // give control back to player
-        player->startControl(entity);
+        this->player_->startControl(this->entity_);
         this->setActive(false);
         this->controllableEntity_ = NULL;
 
-        if (docking)
-            dock->dockingAnimationFinished(player);
+        if (this->docking_)
+            this->dock_->dockingAnimationFinished(this->player_);
         /*else
             dock->undockingAnimationFinished(player);*/

code/branches/presentation/src/modules/docking/DockingController.h

@@ -49 +49 @@
             void takeControl(bool docking);
 
-            void setDock(Dock* dock) { this->dock = dock; }
-            void setPlayer(PlayerInfo* player) { this->player = player; }
+            void setDock(Dock* dock) { this->dock_ = dock; }
+            void setPlayer(PlayerInfo* player) { this->player_ = player; }
 
         protected:
@@ -56 +56 @@
 
         private:
-            bool docking;
+            bool docking_;
 
-            Dock* dock;
-            PlayerInfo* player;
+            Dock* dock_;
+            PlayerInfo* player_;
 
-            ControllableEntity* entity;
+            ControllableEntity* entity_;
     };
 }

code/branches/presentation/src/modules/docking/DockingEffect.cc

@@ -62 +62 @@
 
     DockingTarget *DockingEffect::findTarget(std::string name) {
-        for (ObjectList<DockingTarget>::iterator it = ObjectList<DockingTarget>::begin();
-                                 it != ObjectList<DockingTarget>::end(); ++it)
+        for (ObjectList<DockingTarget>::iterator it = ObjectList<DockingTarget>::begin(); it != ObjectList<DockingTarget>::end(); ++it)
         {
             if ((*it)->getName().compare(name) == 0)

code/branches/presentation/src/modules/docking/DockingTarget.cc

@@ -60 +60 @@
 
     void DockingTarget::setName(const std::string& str) {
-        this->name = str;
+        this->name_ = str;
     }
 
     const std::string& DockingTarget::getName() const {
-        return this->name;
+        return this->name_;
     }
 }

code/branches/presentation/src/modules/docking/DockingTarget.h

@@ -55 +55 @@
     {
         private:
-            std::string name;
+            std::string name_;
 
         public:

code/branches/presentation/src/modules/docking/MoveToDockingTarget.cc

@@ -52 +52 @@
     bool MoveToDockingTarget::docking(PlayerInfo *player)
     {
-        assert(parent);
+        assert(this->parent_);
 
         DockingController *dockingController = new DockingController(this);
-        dockingController->setDock(parent);
+        dockingController->setDock(this->parent_);
         dockingController->setPlayer(player);
         dockingController->takeControl(true);
@@ -65 +65 @@
     {
         //TODO: Investigate strange things...
-        parent->detach((WorldEntity*)player->getControllableEntity());
+        this->parent_->detach((WorldEntity*)player->getControllableEntity());
 
-        parent->undockingAnimationFinished(player);
+        this->parent_->undockingAnimationFinished(player);
         return true;
     }