Changeset 10916 for code/branches/cpp11_v2/src/orxonox/worldentities

Timestamp:

Dec 2, 2015, 11:22:03 PM (10 years ago)

Author:

landauf

Message:

use actual types instead of 'auto'. only exception is for complicated template types, e.g. when iterating over a map

Location:

code/branches/cpp11_v2/src/orxonox/worldentities

Files:

• ControllableEntity.cc (modified) (3 diffs)
• EffectContainer.cc (modified) (1 diff)
• WorldEntity.cc (modified) (4 diffs)
• pawns/ModularSpaceShip.cc (modified) (4 diffs)
• pawns/SpaceShip.cc (modified) (6 diffs)
• pawns/TeamBaseMatchBase.cc (modified) (1 diff)

code/branches/cpp11_v2/src/orxonox/worldentities/ControllableEntity.cc

@@ -165 +165 @@
     {
         unsigned int i = 0;
-        for (const auto & elem : this->cameraPositions_)
+        for (CameraPosition* cameraPosition : this->cameraPositions_)
         {
             if (i == index)
-                return (elem);
+                return cameraPosition;
             ++i;
         }
@@ -180 +180 @@
 
         unsigned int counter = 0;
-        for (const auto & elem : this->cameraPositions_)
-        {
-            if ((elem) == this->currentCameraPosition_)
+        for (CameraPosition* cameraPosition : this->cameraPositions_)
+        {
+            if (cameraPosition == this->currentCameraPosition_)
                 break;
             counter++;
@@ -477 +477 @@
         if (parent)
         {
-            for (auto & elem : this->cameraPositions_)
-                if ((elem)->getIsAbsolute())
-                    parent->attach((elem));
+            for (CameraPosition* cameraPosition : this->cameraPositions_)
+                if (cameraPosition->getIsAbsolute())
+                    parent->attach(cameraPosition);
         }
     }

code/branches/cpp11_v2/src/orxonox/worldentities/EffectContainer.cc

@@ -89 +89 @@
     {
         unsigned int i = 0;
-        for (const auto & elem : this->effects_)
+        for (WorldEntity* effect : this->effects_)
             if (i == index)
-                return (elem);
+                return effect;
         return nullptr;
     }

code/branches/cpp11_v2/src/orxonox/worldentities/WorldEntity.cc

@@ -233 +233 @@
 
             // iterate over all children and change their activity as well
-            for (const auto & elem : this->getAttachedObjects())
+            for (WorldEntity* object : this->getAttachedObjects())
             {
                 if(!this->isActive())
                 {
-                    (elem)->bActiveMem_ = (elem)->isActive();
-                    (elem)->setActive(this->isActive());
+                    object->bActiveMem_ = object->isActive();
+                    object->setActive(this->isActive());
                 }
                 else
                 {
-                    (elem)->setActive((elem)->bActiveMem_);
+                    object->setActive(object->bActiveMem_);
                 }
             }
@@ -259 +259 @@
         {
             // iterate over all children and change their visibility as well
-            for (const auto & elem : this->getAttachedObjects())
+            for (WorldEntity* object : this->getAttachedObjects())
             {
                 if(!this->isVisible())
                 {
-                    (elem)->bVisibleMem_ = (elem)->isVisible();
-                    (elem)->setVisible(this->isVisible());
+                    object->bVisibleMem_ = object->isVisible();
+                    object->setVisible(this->isVisible());
                 }
                 else
                 {
-                    (elem)->setVisible((elem)->bVisibleMem_);
+                    object->setVisible(object->bVisibleMem_);
                 }
             }
@@ -518 +518 @@
     {
         unsigned int i = 0;
-        for (const auto & elem : this->children_)
+        for (WorldEntity* child : this->children_)
         {
             if (i == index)
-                return (elem);
+                return child;
             ++i;
         }
@@ -938 +938 @@
         // Recalculate mass
         this->childrenMass_ = 0.0f;
-        for (const auto & elem : this->children_)
-            this->childrenMass_ += (elem)->getMass();
+        for (WorldEntity* child : this->children_)
+            this->childrenMass_ += child->getMass();
         recalculateMassProps();
         // Notify parent WE

code/branches/cpp11_v2/src/orxonox/worldentities/pawns/ModularSpaceShip.cc

@@ -99 +99 @@
             }
             // iterate through all attached parts
-            for(auto & elem : this->partList_)
+            for(ShipPart* part : this->partList_)
             {
                 // if the name of the part matches the name of the object, add the object to that parts entitylist (unless it was already done).
-                if((elem->getName() == this->getAttachedObject(i)->getName()) && !elem->hasEntity(orxonox_cast<StaticEntity*>(this->getAttachedObject(i))))
+                if((part->getName() == this->getAttachedObject(i)->getName()) && !part->hasEntity(orxonox_cast<StaticEntity*>(this->getAttachedObject(i))))
                 {
                     // The Entity is added to the part's entityList_
-                    elem->addEntity(orxonox_cast<StaticEntity*>(this->getAttachedObject(i)));
+                    part->addEntity(orxonox_cast<StaticEntity*>(this->getAttachedObject(i)));
                     // An entry in the partMap_ is created, assigning the part to the entity.
-                    this->addPartEntityAssignment((StaticEntity*)(this->getAttachedObject(i)), elem);
+                    this->addPartEntityAssignment((StaticEntity*)(this->getAttachedObject(i)), part);
                 }
             }
@@ -146 +146 @@
     ShipPart* ModularSpaceShip::getPartOfEntity(StaticEntity* entity) const
     {
-        for (const auto & elem : this->partMap_)
-        {
-            if (elem.first == entity)
-                return elem.second;
+        for (const auto& mapEntry : this->partMap_)
+        {
+            if (mapEntry.first == entity)
+                return mapEntry.second;
         }
         return nullptr;
@@ -242 +242 @@
     ShipPart* ModularSpaceShip::getShipPartByName(std::string name)
     {
-        for(auto & elem : this->partList_)
-        {
-            if(orxonox_cast<ShipPart*>(elem)->getName() == name)
-            {
-                return orxonox_cast<ShipPart*>(elem);
+        for(ShipPart* part : this->partList_)
+        {
+            if(orxonox_cast<ShipPart*>(part)->getName() == name)
+            {
+                return orxonox_cast<ShipPart*>(part);
             }
         }
@@ -256 +256 @@
     @brief
         Check whether the SpaceShip has a particular Engine.
-    @param engine
+    @param search
         A pointer to the Engine to be checked.
     */
-    bool ModularSpaceShip::hasShipPart(ShipPart* part) const
-    {
-        for(auto & elem : this->partList_)
-        {
-            if(elem == part)
+    bool ModularSpaceShip::hasShipPart(ShipPart* search) const
+    {
+        for(ShipPart* part : this->partList_)
+        {
+            if(part == search)
                 return true;
         }

code/branches/cpp11_v2/src/orxonox/worldentities/pawns/SpaceShip.cc

@@ -158 +158 @@
 
         // Run the engines
-        for(auto & elem : this->engineList_)
-            (elem)->run(dt);
+        for(Engine* engine : this->engineList_)
+            engine->run(dt);
 
         if (this->hasLocalController())
@@ -313 +313 @@
     @brief
         Check whether the SpaceShip has a particular Engine.
-    @param engine
+    @param search
         A pointer to the Engine to be checked.
     */
-    bool SpaceShip::hasEngine(Engine* engine) const
-    {
-        for(auto & elem : this->engineList_)
-        {
-            if(elem == engine)
+    bool SpaceShip::hasEngine(Engine* search) const
+    {
+        for(Engine* engine : this->engineList_)
+        {
+            if(engine == search)
                 return true;
         }
@@ -350 +350 @@
     Engine* SpaceShip::getEngineByName(const std::string& name)
     {
-        for(auto & elem : this->engineList_)
-            if(elem->getName() == name)
-                return elem;
+        for(Engine* engine : this->engineList_)
+            if(engine->getName() == name)
+                return engine;
 
         orxout(internal_warning) << "Couldn't find Engine with name \"" << name << "\"." << endl;
@@ -396 +396 @@
     void SpaceShip::addSpeedFactor(float factor)
     {
-        for(auto & elem : this->engineList_)
-            elem->addSpeedMultiply(factor);
+        for(Engine* engine : this->engineList_)
+            engine->addSpeedMultiply(factor);
     }
 
@@ -408 +408 @@
     void SpaceShip::addSpeed(float speed)
     {
-        for(auto & elem : this->engineList_)
-            elem->addSpeedAdd(speed);
+        for(Engine* engine : this->engineList_)
+            engine->addSpeedAdd(speed);
     }
 
@@ -436 +436 @@
     {
         float speed=0;
-        for(auto & elem : this->engineList_)
-        {
-            if(elem->getMaxSpeedFront() > speed)
-                speed = elem->getMaxSpeedFront();
+        for(Engine* engine : this->engineList_)
+        {
+            if(engine->getMaxSpeedFront() > speed)
+                speed = engine->getMaxSpeedFront();
         }
         return speed;

code/branches/cpp11_v2/src/orxonox/worldentities/pawns/TeamBaseMatchBase.cc

@@ -80 +80 @@
 
         std::set<WorldEntity*> attachments = this->getAttachedObjects();
-        for (const auto & attachment : attachments)
+        for (WorldEntity* attachment : attachments)
         {
-            if ((attachment)->isA(Class(TeamColourable)))
+            if (attachment->isA(Class(TeamColourable)))
             {
                 TeamColourable* tc = orxonox_cast<TeamColourable*>(attachment);