Changeset 10821 for code/branches/cpp11_v2/src/modules/questsystem/GlobalQuest.cc

Timestamp:

Nov 21, 2015, 7:05:53 PM (8 years ago)

Author:

muemart

Message:

Run clang-modernize -loop-convert

• Again, not all possible loops were converted
• It can do pretty cool transformations, but I had to fix a few compile errors, so there might be some runtime errors lurking around too

File:

• code/branches/cpp11_v2/src/modules/questsystem/GlobalQuest.cc (modified) (3 diffs)

code/branches/cpp11_v2/src/modules/questsystem/GlobalQuest.cc

@@ -94 +94 @@
 
         // Iterate through all players possessing this Quest.
-        for(std::set<PlayerInfo*>::const_iterator it = players_.begin(); it != players_.end(); it++)
-            QuestEffect::invokeEffects(*it, this->getFailEffectList());
+        for(const auto & elem : players_)
+            QuestEffect::invokeEffects(elem, this->getFailEffectList());
 
         return true;
@@ -119 +119 @@
 
         // Iterate through all players possessing the Quest.
-        for(std::set<PlayerInfo*>::const_iterator it = players_.begin(); it != players_.end(); it++)
-            QuestEffect::invokeEffects(*it, this->getCompleteEffectList());
+        for(const auto & elem : players_)
+            QuestEffect::invokeEffects(elem, this->getCompleteEffectList());
 
         Quest::complete(player);
@@ -242 +242 @@
     {
         int i = index;
-        for (std::list<QuestEffect*>::const_iterator effect = this->rewards_.begin(); effect != this->rewards_.end(); ++effect)
+        for (const auto & elem : this->rewards_)
         {
             if(i == 0)
-               return *effect;
+               return elem;
 
             i--;