Changeset 9305 for code/branches/presentation2012merge/src/modules/pickup/items

Timestamp:

Jun 18, 2012, 9:54:49 PM (12 years ago)

Author:

landauf

Message:

simplified code a little by using MultiType instead of explicit conversion

Location:

code/branches/presentation2012merge/src/modules/pickup/items

Files:

• DamageBoostPickup.cc (modified) (1 diff)
• DronePickup.cc (modified) (1 diff)
• HealthPickup.cc (modified) (1 diff)
• InvisiblePickup.cc (modified) (1 diff)
• MetaPickup.cc (modified) (1 diff)
• ShieldPickup.cc (modified) (1 diff)
• ShrinkPickup.cc (modified) (1 diff)
• SpeedPickup.cc (modified) (1 diff)

code/branches/presentation2012merge/src/modules/pickup/items/DamageBoostPickup.cc

@@ -82 +82 @@
     void DamageBoostPickup::initializeIdentifier(void)
     {
-        std::stringstream stream;
-        stream << this->getDuration();
-        std::string type1 = "duration";
-        std::string val1 = stream.str();
-        this->pickupIdentifier_->addParameter(type1, val1);
-
-        stream.clear();
-        stream << this->getDamageMultiplier();
-        std::string type2 = "damageMultiplier";
-        std::string val2 = stream.str();
-        this->pickupIdentifier_->addParameter(type2, val2);
-
+        this->pickupIdentifier_->addParameter("duration", this->getDuration());
+        this->pickupIdentifier_->addParameter("damageMultiplier", this->getDamageMultiplier());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/DronePickup.cc

@@ -85 +85 @@
     void DronePickup::initializeIdentifier(void)
     {
-        std::string val = this->getDroneTemplate();
-        std::string type = "droneTemplate";
-        this->pickupIdentifier_->addParameter(type, val);
+        this->pickupIdentifier_->addParameter("droneTemplate", this->getDroneTemplate());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/HealthPickup.cc

@@ -91 +91 @@
     void HealthPickup::initializeIdentifier(void)
     {
-        std::stringstream stream;
-        stream << this->getHealth();
-        std::string type1 = "health";
-        std::string val1 = stream.str();
-        this->pickupIdentifier_->addParameter(type1, val1);
-
-        std::string val2 = this->getHealthType();
-        std::string type2 = "healthType";
-        this->pickupIdentifier_->addParameter(type2, val2);
-
-        stream.clear();
-        stream << this->getHealthRate();
-        std::string val3 = stream.str();
-        std::string type3 = "healthRate";
-        this->pickupIdentifier_->addParameter(type3, val3);
+        this->pickupIdentifier_->addParameter("health", this->getHealth());
+        this->pickupIdentifier_->addParameter("healthType", this->getHealthType());
+        this->pickupIdentifier_->addParameter("healthRate", this->getHealthRate());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/InvisiblePickup.cc

@@ -83 +83 @@
     void InvisiblePickup::initializeIdentifier(void)
     {
-        std::stringstream stream;
-        stream << this->getDuration();
-        std::string type1 = "duration";
-        std::string val1 = stream.str();
-        this->pickupIdentifier_->addParameter(type1, val1);
+        this->pickupIdentifier_->addParameter("duration", this->getDuration());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/MetaPickup.cc

@@ -90 +90 @@
     void MetaPickup::initializeIdentifier(void)
     {
-        std::string val = this->getMetaType();
-        std::string type = "metaType";
-        this->pickupIdentifier_->addParameter(type, val);
+        this->pickupIdentifier_->addParameter("metaType", this->getMetaType());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/ShieldPickup.cc

@@ -84 +84 @@
     void ShieldPickup::initializeIdentifier(void)
     {
-        std::stringstream stream;
-        stream << this->getDuration();
-        std::string type1 = "duration";
-        std::string val1 = stream.str();
-        this->pickupIdentifier_->addParameter(type1, val1);
-
-        stream.clear();
-        stream << this->getShieldHealth();
-        std::string type2 = "ShieldHealth";
-        std::string val2 = stream.str();
-        this->pickupIdentifier_->addParameter(type2, val2);
-
-        stream.clear();
-        stream << this->getShieldAbsorption();
-        std::string type3 = "ShieldAbsorption";
-        std::string val3 = stream.str();
-        this->pickupIdentifier_->addParameter(type3, val3);
-
+        this->pickupIdentifier_->addParameter("duration", this->getDuration());
+        this->pickupIdentifier_->addParameter("ShieldHealth", this->getShieldHealth());
+        this->pickupIdentifier_->addParameter("ShieldAbsorption", this->getShieldAbsorption());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/ShrinkPickup.cc

@@ -83 +83 @@
     void ShrinkPickup::initializeIdentifier(void)
     {
-        std::stringstream stream;
-        stream << this->getShrinkFactor();
-        std::string type1 = "shrinkFactor";
-        std::string val1 = stream.str();
-        this->pickupIdentifier_->addParameter(type1, val1);
-
-        stream.clear();
-        stream << this->getDuration();
-        std::string val2 = stream.str();
-        std::string type2 = "duration";
-        this->pickupIdentifier_->addParameter(type2, val2);
-
-        stream.clear();
-        stream << this->getShrinkDuration();
-        std::string val3 = stream.str();
-        std::string type3 = "shrinkDuration";
-        this->pickupIdentifier_->addParameter(type3, val3);
+        this->pickupIdentifier_->addParameter("shrinkFactor", this->getShrinkFactor());
+        this->pickupIdentifier_->addParameter("duration", this->getDuration());
+        this->pickupIdentifier_->addParameter("shrinkDuration", this->getShrinkDuration());
     }
 

code/branches/presentation2012merge/src/modules/pickup/items/SpeedPickup.cc

@@ -84 +84 @@
     void SpeedPickup::initializeIdentifier(void)
     {
-        std::stringstream stream;
-        stream << this->getDuration();
-        std::string type1 = "duration";
-        std::string val1 = stream.str();
-        this->pickupIdentifier_->addParameter(type1, val1);
-
-        stream.clear();
-        stream << this->getSpeedAdd();
-        std::string type2 = "speedAdd";
-        std::string val2 = stream.str();
-        this->pickupIdentifier_->addParameter(type2, val2);
-
-        stream.clear();
-        stream << this->getSpeedMultiply();
-        std::string type3 = "speedMultiply";
-        std::string val3 = stream.str();
-        this->pickupIdentifier_->addParameter(type3, val3);
+        this->pickupIdentifier_->addParameter("duration", this->getDuration());
+        this->pickupIdentifier_->addParameter("speedAdd", this->getSpeedAdd());
+        this->pickupIdentifier_->addParameter("speedMultiply", this->getSpeedMultiply());
     }