Changeset 7177 for code/trunk/src/libraries/core/Executor.h

Timestamp:

Aug 18, 2010, 1:52:55 AM (15 years ago)

Author:

landauf

Message:

fixed a potential problem introduced in r7158 - calling an executor on a temporary object shouldn't change the internal state of the underlying functor.

File:

• code/trunk/src/libraries/core/Executor.h (modified) (1 diff)

code/trunk/src/libraries/core/Executor.h

@@ -183 +183 @@
             bool parse(T* object, const std::string& params, const std::string& delimiter = " ") const
             {
-                static_cast<FunctorMember<T>*>(this->functor_)->setObject(object);
-                if (Executor::parse(params, delimiter))
-                    return true;
-                else
-                {
-                    static_cast<FunctorMember<T>*>(this->functor_)->setObject((T*)NULL);
-                    return false;
-                }
+                FunctorMember<T>* functorMember = static_cast<FunctorMember<T>*>(this->functor_);
+
+                const typename FunctorMember<T>::Objects& objects = functorMember->getObjects();
+
+                functorMember->setObject(object);
+                bool result = Executor::parse(params, delimiter);
+                functorMember->setObjects(objects);
+
+                return result;
             }
 
             bool parse(const T* object, const std::string& params, const std::string& delimiter = " ") const
             {
-                static_cast<FunctorMember<T>*>(this->functor_)->setObject(object);
-                if (Executor::parse(params, delimiter))
-                    return true;
-                else
-                {
-                    static_cast<FunctorMember<T>*>(this->functor_)->setObject((T*)NULL);
-                    return false;
-                }
+                FunctorMember<T>* functorMember = static_cast<FunctorMember<T>*>(this->functor_);
+
+                const typename FunctorMember<T>::Objects& objects = functorMember->getObjects();
+
+                functorMember->setObject(object);
+                bool result = Executor::parse(params, delimiter);
+                functorMember->setObjects(objects);
+
+                return result;
             }
     };