Changeset 6432 for code/branches/gamestate/src/libraries/core/ArgumentCompletionFunctions.cc

Timestamp:

Dec 29, 2009, 10:30:19 PM (14 years ago)

Author:

rgrieder

Message:

Changed the way config values associated with general settings (ConfigFileType::Settings) are handled:

• ConfigFileManager only handles config files listed in the ConfigFileType enum (normal enum again)
• ConfigFileManager only takes care of ConfigFiles and returns a pointer to the right one, just two functions left. —> use like: ConfigFileManager::getInstance().getConfigFile(myType)→doSomething();
• Moved all code (except for the argument completion functions) relating to ConfigFileType::Settings to a new class: SettingsConfigFile, which is a Singleton (it doesn't make sense to have multiple instances unless you start coding a lot more)
• SettingsConfigFile handles config value containers according to their section and entry in the ini file, not according to class and variables names. (In most cases it will be class and variable names though)
• SettingsConfigFile supports:
  • clear() (removes any file entries not associated to a config value container)
  • updateConfigValues() (does exactly that through the identifier)
  • config, tconfig and getConfig
  • commands listed above are exported to tolua, and tconfig, config and getConfig were given shortcuts in Lua (e.g. orxonox.config)
• If you need to organise ConfigFiles yourself, just do it without the ConfigFileManager, like the KeyBinder does.
• All getValue() functions have been split into getOrCreateValue() and getValue(), which is const
• Removed obsolete config value management code in the Identifier (it still stores and destroys them and provides access to them)

All of that leads to one HUGE advantage:
"config OutputHandler softDebugLevelInGameConsole"
works now (any further implications are up to the reader…)
(it didn't work before because the actual config value container is in the InGameConsole singleton)

File:

• code/branches/gamestate/src/libraries/core/ArgumentCompletionFunctions.cc (modified) (2 diffs)

code/branches/gamestate/src/libraries/core/ArgumentCompletionFunctions.cc

@@ -36 +36 @@
 #include "util/StringUtils.h"
 #include "Identifier.h"
+#include "ConfigFileManager.h"
 #include "ConfigValueContainer.h"
 #include "TclThreadManager.h"
@@ -96 +97 @@
         }
 
-        ARGUMENT_COMPLETION_FUNCTION_IMPLEMENTATION(configvalueclasses)()
+        ARGUMENT_COMPLETION_FUNCTION_IMPLEMENTATION(settingssections)()
         {
-            ArgumentCompletionList classlist;
+            ArgumentCompletionList sectionList;
 
-            for (std::map<std::string, Identifier*>::const_iterator it = Identifier::getStringIdentifierMapBegin(); it != Identifier::getStringIdentifierMapEnd(); ++it)
-                if (it->second->hasConfigValues())
-                    classlist.push_back(ArgumentCompletionListElement(it->first, getLowercase(it->first)));
+            const std::set<std::string>& names = SettingsConfigFile::getInstance().getSectionNames();
+            for (std::set<std::string>::const_iterator it = names.begin(); it != names.end(); ++it)
+                sectionList.push_back(ArgumentCompletionListElement(*it, getLowercase(*it)));
 
-            return classlist;
+            return sectionList;
         }
 
-        ARGUMENT_COMPLETION_FUNCTION_IMPLEMENTATION(configvalues)(const std::string& fragment, const std::string& classname)
+        ARGUMENT_COMPLETION_FUNCTION_IMPLEMENTATION(settingsentries)(const std::string& fragment, const std::string& section)
         {
-            ArgumentCompletionList configvalues;
-            std::map<std::string, Identifier*>::const_iterator identifier = Identifier::getLowercaseStringIdentifierMap().find(getLowercase(classname));
+            ArgumentCompletionList entryList;
+            SettingsConfigFile& settings = SettingsConfigFile::getInstance();
+            const std::string& sectionLC = getLowercase(section);
 
-            if (identifier != Identifier::getLowercaseStringIdentifierMapEnd() && identifier->second->hasConfigValues())
+            SettingsConfigFile::ContainerMap::const_iterator upper = settings.getContainerUpperBound(sectionLC);
+            for (SettingsConfigFile::ContainerMap::const_iterator it = settings.getContainerLowerBound(sectionLC); it != upper; ++it)
+                entryList.push_back(ArgumentCompletionListElement(it->second.second->getName(), it->second.first));
+
+            return entryList;
+        }
+
+        ARGUMENT_COMPLETION_FUNCTION_IMPLEMENTATION(settingsvalue)(const std::string& fragment, const std::string& entry, const std::string& section)
+        {
+            ArgumentCompletionList oldValue;
+            SettingsConfigFile& settings = SettingsConfigFile::getInstance();
+            const std::string& sectionLC = getLowercase(section);
+            const std::string& entryLC = getLowercase(entry);
+
+            SettingsConfigFile::ContainerMap::const_iterator upper = settings.getContainerUpperBound(sectionLC);
+            for (SettingsConfigFile::ContainerMap::const_iterator it = settings.getContainerLowerBound(sectionLC); it != upper; ++it)
             {
-                for (std::map<std::string, ConfigValueContainer*>::const_iterator it = identifier->second->getConfigValueMapBegin(); it != identifier->second->getConfigValueMapEnd(); ++it)
-                    configvalues.push_back(ArgumentCompletionListElement(it->first, getLowercase(it->first)));
+                if (it->second.first == entryLC)
+                {
+                    const std::string& valuestring = it->second.second->toString();
+                    oldValue.push_back(ArgumentCompletionListElement(valuestring, getLowercase(valuestring), "Old value: " + valuestring));
+                }
             }
 
-            return configvalues;
-        }
-
-        ARGUMENT_COMPLETION_FUNCTION_IMPLEMENTATION(configvalue)(const std::string& fragment, const std::string& varname, const std::string& classname)
-        {
-            ArgumentCompletionList oldvalue;
-            std::map<std::string, Identifier*>::const_iterator identifier = Identifier::getLowercaseStringIdentifierMap().find(getLowercase(classname));
-            if (identifier != Identifier::getLowercaseStringIdentifierMapEnd())
-            {
-                std::map<std::string, ConfigValueContainer*>::const_iterator variable = identifier->second->getLowercaseConfigValueMap().find(getLowercase(varname));
-                if (variable != identifier->second->getLowercaseConfigValueMapEnd())
-                {
-                    const std::string& valuestring = variable->second->toString();
-                    oldvalue.push_back(ArgumentCompletionListElement(valuestring, getLowercase(valuestring), "Old value: " + valuestring));
-                }
-            }
-            return oldvalue;
+            return oldValue;
         }