Changeset 5209 in orxonox.OLD

Timestamp:

Sep 20, 2005, 11:22:46 PM (19 years ago)

Author:

bensch

Message:

orxonox/trunk: valgrind's second fruits….. the char-arrays
some time in the near future i will hopefully be faster in interpreting this WALLgrind… but it is great, i can tell you (or at least anyone that reads this

Location:

trunk/src

Files:

• lib/coord/p_node.cc (modified) (1 diff)
• lib/coord/p_node.h (modified) (2 diffs)
• lib/shell/shell.cc (modified) (1 diff)
• lib/util/list.h (modified) (1 diff)
• lib/util/substring.cc (modified) (1 diff)
• story_entities/world.cc (modified) (2 diffs)

trunk/src/lib/coord/p_node.cc

@@ -108 +108 @@
   this->bRelDirChanged = true;
   this->parent = parent;
+  this->parentMode = PNODE_PARENT_MODE_DEFAULT;
 
   // iterators

trunk/src/lib/coord/p_node.h

@@ -46 +46 @@
 
 //! The default mode of the translation-binding.
-#define DEFAULT_MODE PNODE_ALL
+#define PNODE_PARENT_MODE_DEFAULT PNODE_ALL
 
 
@@ -98 +98 @@
 
 
-  void addChild (PNode* child, int parentingMode = DEFAULT_MODE);
+  void addChild (PNode* child, int parentingMode = PNODE_PARENT_MODE_DEFAULT);
   void addChild (const char* childName);
   void removeChild (PNode* child);

trunk/src/lib/shell/shell.cc

@@ -64 +64 @@
   // BUFFER
   this->bufferText = NULL;
-  this->setBufferDisplaySize(10);
+  this->bufferDisplaySize = 10;
 
   // INPUT LINE

trunk/src/lib/util/list.h

@@ -365 +365 @@
   inline tIterator<T>::tIterator (const tList<T>* list)
 {
-  this->currentEl = list->first;
+  this->currentEl = NULL;
   this->tmpEl = NULL;
   this->list = list;

trunk/src/lib/util/substring.cc

@@ -70 +70 @@
     }
 
+    l = strlen( offset);
     strings[i] = new char[l + 1];
-    l = strlen( offset);
     strncpy( strings[i], offset, l);
     strings[i][l] = '\0';

trunk/src/story_entities/world.cc

@@ -265 +265 @@
       PRINTF(2)("World is missing a proper 'name'\n");
       string = "Unknown";
-      temp = new char[strlen(string + 2)];
+      temp = new char[strlen(string)+1];
       strcpy( temp, string);
       this->setName(temp);
@@ -271 +271 @@
   else
     {
-      temp = new char[strlen(string + 2)];
+      temp = new char[strlen(string )+1];
       strcpy( temp, string);
       this->setName(temp);