Changeset 2514 for code/branches/presentation/src/orxonox/objects/collisionshapes/PlaneCollisionShape.cc

Timestamp:

Dec 21, 2008, 2:44:00 PM (15 years ago)

Author:

rgrieder

Message:

Resolved four issues with the collision shapes:

• NetworkCallback will of course not call functions virtually
• CompoundCollisionShapes with a WorldEntity parent don't have to attach themselves when synchronised
• Just in case: When changing a CollisionShape, the old gets destroyed AFTER everything has been updated
• CompoundCollisionShapes with a WorldEntity parent now update both the WE and the CompoundCollisionShape when something changes

Other changes

• Also replaced some redundant code while at it (updating the shapes was done individually)
• Like in WE, the CompoundCollisionShape deletes all its children when being destroyed itself. This requires in WE that the children get detached before the CompoundCollisionShape gets deleted.

File:

• code/branches/presentation/src/orxonox/objects/collisionshapes/PlaneCollisionShape.cc (modified) (3 diffs)

code/branches/presentation/src/orxonox/objects/collisionshapes/PlaneCollisionShape.cc

@@ -46 +46 @@
         this->normal_ = Vector3(0, 1, 0);
         this->offset_ = 0.0f;
-        updatePlane();
+        updateShape();
 
         this->registerVariables();
@@ -59 +59 @@
     void PlaneCollisionShape::registerVariables()
     {
-        registerVariable(this->normal_, variableDirection::toclient, new NetworkCallback<PlaneCollisionShape>(this, &PlaneCollisionShape::updatePlane));
-        registerVariable(this->offset_, variableDirection::toclient, new NetworkCallback<PlaneCollisionShape>(this, &PlaneCollisionShape::updatePlane));
+        registerVariable(this->normal_, variableDirection::toclient, new NetworkCallback<CollisionShape>(this, &CollisionShape::updateShape));
+        registerVariable(this->offset_, variableDirection::toclient, new NetworkCallback<CollisionShape>(this, &CollisionShape::updateShape));
     }
 
@@ -71 +71 @@
     }
 
-    void PlaneCollisionShape::updatePlane()
+    btCollisionShape* PlaneCollisionShape::createNewShape() const
     {
-        if (this->collisionShape_)
-            delete this->collisionShape_;
-        this->collisionShape_ = new btStaticPlaneShape(omni_cast<btVector3>(this->normal_), this->offset_);
-        this->updateParent();
+        return new btStaticPlaneShape(omni_cast<btVector3>(this->normal_), this->offset_);
     }
 }