Changeset 1637 for code/branches/input/src/core/input/Button.cc

Timestamp:

Jul 20, 2008, 6:49:24 PM (16 years ago)

Author:

rgrieder

Message:

Finally! The InputManager is now working like I imagined it to. And it's even easier to use it as well.
A little explanation: Every time you change something about the input distribution, it is a change of 'state' represented by the class 'InputState'.
That can be for instance: "console", "game", "gui", etc. Every state has a name and a priority which describes who comes first. Now if one state doesn't handle mouse input or instance, then the one with the next lower priority gets it. To prevent that, you can add the 'EmptyHandler' to the state with setMouseHandler.
InputState is just an abstract base class. There are two classes implementing it: SimpleInputState and ExtendedInputState. The latter allows for multiple input handlers for one single device.

Basically, what you need to know is what you see in Orxonox.cc, InGameConsole.cc and Shell.cc.

File:

• code/branches/input/src/core/input/Button.cc (modified) (2 diffs)

code/branches/input/src/core/input/Button.cc

@@ -88 +88 @@
                     '\\', false, '"', false, '(', ')', false, '\0');
 
-                unsigned int iToken = 0;
-
-                // for real axes, we can feed a ButtonThreshold argument as entire command
-                if (getLowercase(tokens[0]) == "buttonthreshold")
-                {
-                    if (tokens.size() == 1)
-                        continue;
-                    // may fail, but doesn't matter
-                    convertValue(&buttonThreshold_, tokens[1]);
-                    continue;
-                }
-
-                // first argument can be OnPress, OnHold OnRelease or nothing
                 KeybindMode::Enum mode = KeybindMode::None;
-                if (getLowercase(tokens[iToken]) == "onpress")
-                    mode = KeybindMode::OnPress,   iToken++;
-                if (getLowercase(tokens[iToken]) == "onrelease")
-                    mode = KeybindMode::OnRelease, iToken++;
-                if (getLowercase(tokens[iToken]) == "onhold")
-                    mode = KeybindMode::OnHold,    iToken++;
-
-                if (iToken == tokens.size())
-                    continue;
-
-                // second argument can be the amplitude for the case it as an axis command
-                // default amplitude is 1.0f
                 float paramModifier = 1.0f;
-                if (getLowercase(tokens[iToken]) == "scale")
-                {
-                    iToken++;
-                    if (iToken == tokens.size() || !convertValue(&paramModifier, tokens[iToken]))
-                    {
-                        COUT(2) << "Error while parsing key binding " << name_
-                                << ". Numeric expression expected afer 'AxisAmp', switching to default value"
-                                << std::endl;
+                std::string commandStr = "";
+
+                for (unsigned int iToken = 0; iToken < tokens.size(); ++iToken)
+                {
+                    std::string token = getLowercase(tokens[iToken]);
+
+                    if (token == "onpress")
+                        mode = KeybindMode::OnPress;
+                    else if (token == "onrelease")
+                        mode = KeybindMode::OnRelease;
+                    else if (token == "onhold")
+                        mode = KeybindMode::OnHold;
+                    else if (token == "buttonthreshold")
+                    {
+                        // for real axes, we can feed a ButtonThreshold argument
+                        ++iToken;
                         if (iToken == tokens.size())
                             continue;
-                    }
-                    iToken++;
-                }
-
-                // no more arguments expected except for the actual command
-                if (iToken == tokens.size())
+                        // may fail, but doesn't matter (default value already set)
+                        if (!convertValue(&buttonThreshold_, tokens[iToken + 1]))
+                            parseError("Could not parse 'ButtonThreshold' argument. \
+                                Switching to default value.", true);
+                    }
+                    else if (token == "scale")
+                    {
+                        ++iToken;
+                        if (iToken == tokens.size() || !convertValue(&paramModifier, tokens[iToken]))
+                            parseError("Could not parse 'scale' argument. Switching to default value.", true);
+                    }
+                    else
+                    {
+                        // no input related argument
+                        // we interpret everything from here as a command string
+                        while (iToken != tokens.size())
+                            commandStr += tokens[iToken++] + " ";
+                    }
+                }
+
+                if (commandStr == "")
+                {
+                    parseError("No command string given.", false);
                     continue;
-
-                std::string commandStr;
-                while (iToken != tokens.size())
-                    commandStr += tokens[iToken++] + " ";
+                }
 
                 // evaluate the command
                 CommandEvaluation eval = CommandExecutor::evaluate(commandStr);
                 if (!eval.isValid())
+                {
+                    parseError("Command evaluation failed.", true);
                     continue;
+                }
 
                 // check for param command
@@ -215 +215 @@
         return true;
     }
+
+    inline void Button::parseError(std::string message, bool serious)
+    {
+        if (serious)
+        {
+            COUT(2) << "Error while parsing binding for button/axis" << this->name_ << ". "
+                << message << std::endl;
+        }
+        else
+        {
+            COUT(3) << "Warning while parsing binding for button/axis" << this->name_ << ". "
+                << message << std::endl;
+        }
+    }
 }