Changeset 11990 for code/branches/Masterserver_FS18/src/libraries/network/ServerConnection.cc

Timestamp:

May 24, 2018, 3:24:00 PM (6 years ago)

Author:

mdedial

Message:

Clean up code, remove TODOs and dead code.

File:

• code/branches/Masterserver_FS18/src/libraries/network/ServerConnection.cc (modified) (4 diffs)

code/branches/Masterserver_FS18/src/libraries/network/ServerConnection.cc

@@ -39 +39 @@
 namespace orxonox
 {
-
-  // TODO: Calls to the Connection superclass are done as follows:
-  // Connection::startCommunicationThread()
-  // However, these methods are not overridden.
-  // Why can't we just do this->startCommunicationThread()?
-
   /**
    * Constructor
@@ -131 +125 @@
   {
     this->bListening_ = false;
-    disconnectClients();
+    this->disconnectClients();
     Connection::stopCommunicationThread();
     enet_host_destroy(this->host_);
@@ -142 +136 @@
    * @param clientID The ID of the recipient
    * @param channelID The channel ID
-   * TODO: Not sure yet how this actually works
    */
   void ServerConnection::addPacket(ENetPacket *packet, unsigned int clientID, uint8_t channelID)
@@ -148 +141 @@
     if (clientID == NETWORK_PEER_ID_BROADCAST)
     {
-      broadcastPacket(packet, channelID);
+      this->broadcastPacket(packet, channelID);
     }
     else