Changeset 11990 for code/branches/Masterserver_FS18/src/libraries/network/Connection.cc

Timestamp:

May 24, 2018, 3:24:00 PM (6 years ago)

Author:

mdedial

Message:

Clean up code, remove TODOs and dead code.

File:

• code/branches/Masterserver_FS18/src/libraries/network/Connection.cc (modified) (3 diffs)

code/branches/Masterserver_FS18/src/libraries/network/Connection.cc

@@ -72 +72 @@
     delete this->incomingEventsMutex_;
     delete this->outgoingEventsMutex_;
-
-    // TODO: Why is enet_deinitialize() not called here?
-    // Would make sense, since its counterpart, enet_initialize(), is called in the constructor.
   }
 
@@ -172 +169 @@
       
       // Sleep for 1ms
-      // TODO: Why?
       msleep(1);
       
       // Send all waiting outgoing packets
-      // TODO: Why do we need a mutex to read a single variable?
       this->outgoingEventsMutex_->lock();
       uint32_t outgoingEventsCount = this->outgoingEvents_.size();
       this->outgoingEventsMutex_->unlock();
 
-      // TODO: Not convinced about how mutexes are used here, seems kinda pointless
       while(outgoingEventsCount > 0)
       {
@@ -406 +400 @@
   }
 
-
 }