Changeset 11078 for code/branches/shaders_merge/src/orxonox/graphics/LensFlare.cc

Timestamp:

Jan 19, 2016, 10:49:57 PM (8 years ago)

Author:

landauf

Message:

fixed numerous issues:

• fixed memory leaks (delete allocated heap space)
• use 'new' only when necessary
• use orxonox_cast instead of static_cast
• fixed warning in MSVC

also fixed formatting and added certain c++11 features

File:

• code/branches/shaders_merge/src/orxonox/graphics/LensFlare.cc (modified) (6 diffs)

code/branches/shaders_merge/src/orxonox/graphics/LensFlare.cc

@@ -46 +46 @@
     RegisterClass(LensFlare);
     
-    LensFlare::LensFlare(Context* context) : StaticEntity(context), scale_(1.0f), fadeOnViewBorder_(true), fadeResolution_(7), fadeExponent_(2.0f), colour_(new ColourValue(1.0f,0.9f,0.9f))
+    LensFlare::LensFlare(Context* context) : StaticEntity(context), scale_(1.0f), fadeOnViewBorder_(true), fadeResolution_(7), fadeExponent_(2.0f)
     {
         RegisterObject(LensFlare);
         
-        this->lensConfiguration_=new std::vector<LensFlare::Lens*>();
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/burst"),1.0f,1.0f,1.0f)); //main burst
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/burst"),0.7f,1.2f,1.05f)); //secondary burst
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/bursthalo"),0.7f,0.9f,1.0f)); //halo around main burst
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/ring"),0.1f,2.5f,0.9f)); //all the different distanced lenses
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/iris"),0.1f,0.2f,0.5f));
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/halo5"),0.1f,0.3f,0.45f));
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/halo5"),0.4f,0.2f,0.35f));
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/iris"),0.1f,0.4f,0.25f));
-        this->lensConfiguration_->push_back(new LensFlare::Lens(new std::string("lensflare/halo4"),0.05f,0.2f,0.2f));
+        this->lensConfiguration_.emplace_back("lensflare/burst",     1.0f,  1.0f, 1.0f); //main burst
+        this->lensConfiguration_.emplace_back("lensflare/burst",     0.7f,  1.2f, 1.05f); //secondary burst
+        this->lensConfiguration_.emplace_back("lensflare/bursthalo", 0.7f,  0.9f, 1.0f); //halo around main burst
+        this->lensConfiguration_.emplace_back("lensflare/ring",      0.1f,  2.5f, 0.9f); //all the different distanced lenses
+        this->lensConfiguration_.emplace_back("lensflare/iris",      0.1f,  0.2f, 0.5f);
+        this->lensConfiguration_.emplace_back("lensflare/halo5",     0.1f,  0.3f, 0.45f);
+        this->lensConfiguration_.emplace_back("lensflare/halo5",     0.4f,  0.2f, 0.35f);
+        this->lensConfiguration_.emplace_back("lensflare/iris",      0.1f,  0.4f, 0.25f);
+        this->lensConfiguration_.emplace_back("lensflare/halo4",     0.05f, 0.2f, 0.2f);
         
         this->createBillboards();
@@ -100 +99 @@
         this->attach(this->occlusionBillboard_);
         
-        for(std::vector<LensFlare::Lens*>::iterator it = lensConfiguration_->begin(); it != lensConfiguration_->end(); ++it) {
-            Billboard* lensPart=new Billboard(this->getContext());
-            lensPart->setMaterial(*(*it)->material_);
+        for (const LensFlare::Lens& lens : lensConfiguration_)
+        {
+            Billboard* lensPart = new Billboard(this->getContext());
+            lensPart->setMaterial(lens.material_);
             lensPart->disableFrustumCulling();
             lensPart->setVisible(true);
@@ -119 +119 @@
         is the (point-)light source currently visible
     */
-    void LensFlare::updateBillboardStates(Vector3& viewDirection, float dimension, bool lightIsVisible)
+    void LensFlare::updateBillboardStates(const Vector3& viewDirection, float dimension, bool lightIsVisible)
     { 
-        this->occlusionBillboard_->setDefaultDimensions(dimension*0.5f,dimension*0.5f);
+        this->occlusionBillboard_->setDefaultDimensions(dimension * 0.5f, dimension * 0.5f);
         this->occlusionBillboard_->setVisible(lightIsVisible);
-        std::set<WorldEntity*>::const_iterator it = this->getAttachedObjects().begin();
-        it++;
-        for(int i=0; it != this->getAttachedObjects().end(); it++) {
-            Billboard* billboard=static_cast<Billboard*>(*it);
-            LensFlare::Lens* lens=lensConfiguration_->at(i);
-            billboard->setPosition(-viewDirection*(1.0f-lens->position_));
+
+        int i = 0;
+        for (WorldEntity* attachedObject : this->getAttachedObjects())
+        {
+            Billboard* billboard = orxonox_cast<Billboard*>(attachedObject);
+            if (billboard == this->occlusionBillboard_)
+                continue;
+            const LensFlare::Lens& lens = lensConfiguration_.at(i);
+            billboard->setPosition(-viewDirection * (1.0f - lens.position_));
             billboard->setVisible(lightIsVisible);
-            billboard->setDefaultDimensions(dimension*lens->scale_,dimension*lens->scale_);
+            billboard->setDefaultDimensions(dimension * lens.scale_, dimension * lens.scale_);
             i++;
         }
@@ -143 +146 @@
     void LensFlare::updateBillboardAlphas(float alpha)
     {
-        this->colour_->a=alpha;
-        std::set<WorldEntity*>::const_iterator it = this->getAttachedObjects().begin();
-        it++;
-        for(int i=0;it!=this->getAttachedObjects().end(); it++) {
-            ColourValue* cur=new ColourValue(0,0,0,0);
-            (*cur)+= *(this->colour_);
-            cur->a*=lensConfiguration_->at(i)->alpha_;
-            Billboard* billboard=static_cast<Billboard*>(*it);
-            billboard->setColour(*cur);
+        ColourValue cur = this->colour_;
+
+        int i = 0;
+        for (WorldEntity* attachedObject : this->getAttachedObjects())
+        {
+            Billboard* billboard = orxonox_cast<Billboard*>(attachedObject);
+            if (billboard == this->occlusionBillboard_)
+                continue;
+            cur.a = alpha * lensConfiguration_.at(i).alpha_;
+            billboard->setColour(cur);
             i++;
         }
@@ -166 +170 @@
     unsigned int LensFlare::getPointCount(float dimension) const
     {
-        Ogre::Camera* camera=CameraManager::getInstance().getActiveCamera()->getOgreCamera();
+        Ogre::Camera* camera = CameraManager::getInstance().getActiveCamera()->getOgreCamera();
         Vector3 position = this->getWorldPosition();
         Vector3 nX = camera->getDerivedOrientation().xAxis().normalisedCopy();
         Vector3 nY = camera->getDerivedOrientation().yAxis().normalisedCopy();
-        int halfRes=fadeResolution_/2;
-        float resDim=dimension/fadeResolution_;
-        unsigned int count=0;
-        for(int i=-halfRes;i<=halfRes;i++)
-        {
-            for(int j=-halfRes;j<=halfRes;j++)
+        int halfRes = fadeResolution_ / 2;
+        float resDim = dimension / fadeResolution_;
+        unsigned int count = 0;
+        for (int i = -halfRes; i <= halfRes; i++)
+        {
+            for (int j = -halfRes; j <= halfRes; j++)
             {
-                Vector3 point=position+(i*resDim)*nX+(j*resDim)*nY;//generate point samples
-                if(camera->isVisible(point))
+                Vector3 point = position + (i*resDim) * nX + (j*resDim) * nY;//generate point samples
+                if (camera->isVisible(point))
                 {
                     count++;
@@ -191 +195 @@
         if(this->isVisible())
         {
-            Ogre::Camera* camera=CameraManager::getInstance().getActiveCamera()->getOgreCamera(); //get active Ogre Camera Instance, so we can check whether the light source is visible
-            this->cameraDistance_=camera->getDerivedPosition().distance(this->getPosition());
-            float dimension=this->cameraDistance_*this->scale_;
-            if(!this->fadeOnViewBorder_)
+            // get the current distance of the lensflare center from the camera
+            Ogre::Camera* camera = CameraManager::getInstance().getActiveCamera()->getOgreCamera(); //get active Ogre Camera Instance, so we can check whether the light source is visible
+            float cameraDistance = camera->getDerivedPosition().distance(this->getPosition());
+            float dimension = cameraDistance * this->scale_;
+            if (!this->fadeOnViewBorder_)
             {
-                this->fadeResolution_=3;//this is so we can still determine when the billboard has left the screen
+                this->fadeResolution_ = 3;//this is so we can still determine when the billboard has left the screen
             }
-            unsigned int pointCount=this->getPointCount(dimension*0.25f*this->scale_);
-            Vector3 viewDirection=this->getWorldPosition()-camera->getDerivedPosition()-camera->getDerivedDirection()*this->cameraDistance_;
-            updateBillboardStates(viewDirection,dimension,pointCount>0);
-            if(pointCount>0) {
-                Ogre::Sphere* sphere=new Ogre::Sphere(this->getPosition(),dimension*0.25f*this->scale_);
+            unsigned int pointCount = this->getPointCount(dimension * 0.25f * this->scale_);
+            Vector3 viewDirection = this->getWorldPosition() - camera->getDerivedPosition() - camera->getDerivedDirection() * cameraDistance;
+            this->updateBillboardStates(viewDirection, dimension, pointCount > 0);
+            if (pointCount > 0)
+            {
+                Ogre::Sphere sphere(this->getPosition(), dimension * 0.25f * this->scale_);
                 float left, right, top, bottom;
-                camera->projectSphere(*sphere,&left,&top,&right,&bottom);//approximate maximum pixel count of billboard with a sphere
-                delete sphere;
+                camera->projectSphere(sphere, &left, &top, &right, &bottom);//approximate maximum pixel count of billboard with a sphere
                 
                 Ogre::RenderWindow* window = GraphicsManager::getInstance().getRenderWindow();
-                float maxCount=(right-left)*(top-bottom)*window->getWidth()*window->getHeight()*0.25f;
-                float pixelCount=this->getScene()->getRenderQueueListener()->getPixelCount();//get pixel count
-                float ratio=(maxCount<0.0f)?0.0f:(pixelCount/maxCount);//prevent underflow and division by zero
-                float borderRatio=1.0f;
-                if(this->fadeOnViewBorder_)
+                float maxCount = (right - left) * (top - bottom) * window->getWidth() * window->getHeight() * 0.25f;
+                unsigned int pixelCount = this->getScene()->getRenderQueueListener()->getPixelCount();//get pixel count
+                float ratio = (maxCount < 0.0f) ? 0.0f : (1.0f * pixelCount / maxCount);//prevent underflow and division by zero
+                float borderRatio = 1.0f;
+                if (this->fadeOnViewBorder_)
                 {
-                    borderRatio=((float) pointCount)/(((float) fadeResolution_)*((float) fadeResolution_));//ratio for the border fade
+                    borderRatio = ((float) pointCount) / (((float) fadeResolution_) * ((float) fadeResolution_));//ratio for the border fade
                 }
                 //update alpha values of all billboards except the HOQ billboard
-                this->updateBillboardAlphas(std::min(1.0f,std::pow(std::min(ratio,borderRatio),this->fadeExponent_)));
+                this->updateBillboardAlphas(std::min(1.0f, std::pow(std::min(ratio, borderRatio), this->fadeExponent_)));
             }
         }