Changeset 11006 for code/branches/cpp11_v2/src/libraries/network/packet/Acknowledgement.cc

Timestamp:

Dec 30, 2015, 11:34:25 PM (8 years ago)

Author:

landauf

Message:

made some enums in network library strongly typed. for most other enums in network this isn't possible because they are often used like flags (converted to int and compared with binary operators).
packet::Type now uses uint8_t as underlying type which reduces the network traffic (by default the type was int)

File:

• code/branches/cpp11_v2/src/libraries/network/packet/Acknowledgement.cc (modified) (2 diffs)

code/branches/cpp11_v2/src/libraries/network/packet/Acknowledgement.cc

@@ -38 +38 @@
 #define PACKET_FLAGS_ACK    0
 #define _PACKETID           0
-#define _ACKID              _PACKETID + sizeof(packet::Type::Value)
+#define _ACKID              _PACKETID + sizeof(packet::Type)
 
 Acknowledgement::Acknowledgement( unsigned int id, unsigned int peerID )
@@ -45 +45 @@
   flags_ = flags_ | PACKET_FLAGS_ACK;
   data_=new uint8_t[ getSize() ];
-  *(Type::Value *)(data_ + _PACKETID ) = Type::Acknowledgement;
+  *(Type *)(data_ + _PACKETID ) = Type::Acknowledgement;
   *(uint32_t *)(data_ + _ACKID ) = id;
   peerID_=peerID;