Changeset 10821 for code/branches/cpp11_v2/src/orxonox/controllers/FormationController.cc

Timestamp:

Nov 21, 2015, 7:05:53 PM (9 years ago)

Author:

muemart

Message:

Run clang-modernize -loop-convert

• Again, not all possible loops were converted
• It can do pretty cool transformations, but I had to fix a few compile errors, so there might be some runtime errors lurking around too

File:

• code/branches/cpp11_v2/src/orxonox/controllers/FormationController.cc (modified) (7 diffs)

code/branches/cpp11_v2/src/orxonox/controllers/FormationController.cc

@@ -440 +440 @@
                 if(newMaster->slaves_.size() > this->maxFormationSize_) continue;
 
-                for(std::vector<FormationController*>::iterator itSlave = this->slaves_.begin(); itSlave != this->slaves_.end(); itSlave++)
+                for(auto & elem : this->slaves_)
                 {
-                    (*itSlave)->myMaster_ = newMaster;
-                    newMaster->slaves_.push_back(*itSlave);
+                    (elem)->myMaster_ = newMaster;
+                    newMaster->slaves_.push_back(elem);
                 }
                 this->slaves_.clear();
@@ -486 +486 @@
             int i = 1;
 
-            for(std::vector<FormationController*>::iterator it = slaves_.begin(); it != slaves_.end(); it++)
+            for(auto & elem : slaves_)
             {
                 pos = Vector3::ZERO;
@@ -497 +497 @@
                     dest+=FORMATION_LENGTH*(orient*WorldEntity::BACK);
                 }
-                (*it)->setTargetOrientation(orient);
-                (*it)->setTargetPosition(pos);
+                (elem)->setTargetOrientation(orient);
+                (elem)->setTargetPosition(pos);
                 left=!left;
             }
@@ -569 +569 @@
         if(this->state_ != MASTER) return;
 
-        for(std::vector<FormationController*>::iterator it = slaves_.begin(); it != slaves_.end(); it++)
-        {
-            (*it)->state_ = FREE;
-            (*it)->myMaster_ = nullptr;
+        for(auto & elem : slaves_)
+        {
+            (elem)->state_ = FREE;
+            (elem)->myMaster_ = nullptr;
         }
         this->slaves_.clear();
@@ -584 +584 @@
         if(this->state_ != MASTER) return;
 
-        for(std::vector<FormationController*>::iterator it = slaves_.begin(); it != slaves_.end(); it++)
-        {
-            (*it)->state_ = FREE;
-            (*it)->forceFreedom();
-            (*it)->targetPosition_ = this->targetPosition_;
-            (*it)->bShooting_ = true;
+        for(auto & elem : slaves_)
+        {
+            (elem)->state_ = FREE;
+            (elem)->forceFreedom();
+            (elem)->targetPosition_ = this->targetPosition_;
+            (elem)->bShooting_ = true;
 //             (*it)->getControllableEntity()->fire(0);// fire once for fun
         }
@@ -650 +650 @@
             this->slaves_.push_back(this->myMaster_);
             //set this as new master
-            for(std::vector<FormationController*>::iterator it = slaves_.begin(); it != slaves_.end(); it++)
-            {
-                 (*it)->myMaster_=this;
+            for(auto & elem : slaves_)
+            {
+                 (elem)->myMaster_=this;
             }
             this->myMaster_=nullptr;
@@ -694 +694 @@
         if (this->state_ == MASTER)
         {
-            for(std::vector<FormationController*>::iterator it = slaves_.begin(); it != slaves_.end(); it++)
-            {
-                 (*it)->formationMode_ = val;
+            for(auto & elem : slaves_)
+            {
+                 (elem)->formationMode_ = val;
                  if (val == ATTACK)
-                     (*it)->forgetTarget();
+                     (elem)->forgetTarget();
             }
         }