Changeset 10821 for code/branches/cpp11_v2/src/modules/questsystem/effects/AddReward.cc

Timestamp:

Nov 21, 2015, 7:05:53 PM (8 years ago)

Author:

muemart

Message:

Run clang-modernize -loop-convert

• Again, not all possible loops were converted
• It can do pretty cool transformations, but I had to fix a few compile errors, so there might be some runtime errors lurking around too

File:

• code/branches/cpp11_v2/src/modules/questsystem/effects/AddReward.cc (modified) (2 diffs)

code/branches/cpp11_v2/src/modules/questsystem/effects/AddReward.cc

@@ -84 +84 @@
     {
         int i = index;
-        for (std::list<Rewardable*>::const_iterator reward = this->rewards_.begin(); reward != this->rewards_.end(); ++reward)
+        for (const auto & elem : this->rewards_)
         {
             if(i == 0)
-               return *reward;
+               return elem;
             i--;
         }
@@ -106 +106 @@
 
         bool temp = true;
-        for ( std::list<Rewardable*>::iterator reward = this->rewards_.begin(); reward != this->rewards_.end(); ++reward )
-            temp = temp && (*reward)->reward(player);
+        for (auto & elem : this->rewards_)
+            temp = temp && (elem)->reward(player);
 
         orxout(verbose, context::quests) << "Rewardable successfully added to player." << player << " ." << endl;