Changeset 10821 for code/branches/cpp11_v2/src/modules/notifications/NotificationQueue.cc

Timestamp:

Nov 21, 2015, 7:05:53 PM (8 years ago)

Author:

muemart

Message:

Run clang-modernize -loop-convert

• Again, not all possible loops were converted
• It can do pretty cool transformations, but I had to fix a few compile errors, so there might be some runtime errors lurking around too

File:

• code/branches/cpp11_v2/src/modules/notifications/NotificationQueue.cc (modified) (4 diffs)

code/branches/cpp11_v2/src/modules/notifications/NotificationQueue.cc

@@ -206 +206 @@
         {
             // Add all Notifications that have been created after this NotificationQueue was created.
-            for(std::multimap<std::time_t, Notification*>::iterator it = notifications->begin(); it != notifications->end(); it++)
+            for(auto & notification : *notifications)
             {
-                if(it->first >= this->creationTime_)
-                    this->push(it->second, it->first);
+                if(notification.first >= this->creationTime_)
+                    this->push(notification.second, notification.first);
             }
         }
@@ -336 +336 @@
         this->ordering_.clear();
         // Delete all NotificationContainers in the list.
-        for(std::vector<NotificationContainer*>::iterator it = this->notifications_.begin(); it != this->notifications_.end(); it++)
-            delete *it;
+        for(auto & elem : this->notifications_)
+            delete elem;
 
         this->notifications_.clear();
@@ -426 +426 @@
         bool first = true;
         // Iterate through the set of targets.
-        for(std::set<std::string>::const_iterator it = this->targets_.begin(); it != this->targets_.end(); it++)
+        for(const auto & elem : this->targets_)
         {
             if(!first)
@@ -432 +432 @@
             else
                 first = false;
-            stream << *it;
+            stream << elem;
         }