Changeset 10033

Timestamp:

Apr 16, 2014, 8:59:17 PM (10 years ago)

Author:

noep

Message:

Tried to find&solve the segfault. The detach-process itself is not the problem, but the collision on a deleted shape being handled. Maybe try using a smart pointer in the handling process, so that the shape only gets deleted when the process completed?

Location:

code/branches/modularships/src/orxonox

Files:

• collisionshapes/CompoundCollisionShape.cc (modified) (1 diff)
• items/ShipPart.cc (modified) (1 diff)
• worldentities/WorldEntity.cc (modified) (1 diff)
• worldentities/WorldEntity.h (modified) (1 diff)
• worldentities/pawns/ModularSpaceShip.cc (modified) (5 diffs)
• worldentities/pawns/ModularSpaceShip.h (modified) (1 diff)

code/branches/modularships/src/orxonox/collisionshapes/CompoundCollisionShape.cc

@@ -138 +138 @@
         if (this->attachedShapes_.find(shape) != this->attachedShapes_.end())
         {
+            orxout() << "Still going..." << endl;
             this->attachedShapes_.erase(shape);
             if (shape->getCollisionShape())
                 this->compoundShape_->removeChildShape(shape->getCollisionShape()); // TODO: Apparently this is broken?
             shape->notifyDetached();
+            orxout() << "Still going...." << endl;
 
             this->updatePublicShape();
+            orxout() << "Still going....." << endl;
         }
         else

code/branches/modularships/src/orxonox/items/ShipPart.cc

@@ -89 +89 @@
     {
         this->parent_->removeShipPart(this);
+        orxout() << this->getName() << " has died." << endl;
     }
 

code/branches/modularships/src/orxonox/worldentities/WorldEntity.cc

@@ -580 +580 @@
     {
         // Note: The collision shapes may not be detached with this function!
+        orxout() << "WE: detachCS()" << endl;
         this->collisionShape_->detach(shape);
         // Note: this->collisionShape_ already notifies us of any changes.

code/branches/modularships/src/orxonox/worldentities/WorldEntity.h

@@ -72 +72 @@
     {
         friend class Scene;
+        friend class ModularSpaceShip;
 
         public:

code/branches/modularships/src/orxonox/worldentities/pawns/ModularSpaceShip.cc

@@ -40 +40 @@
 #include "items/ShipPart.h"
 #include "worldentities/StaticEntity.h"
+#include "collisionshapes/WorldEntityCollisionShape.h"
 #include <BulletCollision/CollisionShapes/btCollisionShape.h>
 
@@ -78 +79 @@
     {
         // iterate through all attached objects
-        for (unsigned int i=0; i < this->getNumAttachedObj(); i++)
+        for (unsigned int i=0; i < (unsigned int)(this->getNumAttachedObj()); i++)
         {
             if (this->getAttachedObject(i) == NULL)
@@ -179 +180 @@
         //orxout() << "ShipPart of Entity " << cs->getUserPointer() << ": " << this->getPartOfEntity((StaticEntity*)(cs->getUserPointer())) << endl;
 
+        orxout() << "CP before handleHit" << endl;
+
         if (this->getPartOfEntity((StaticEntity*)(cs->getUserPointer())) != NULL)
             this->getPartOfEntity((StaticEntity*)(cs->getUserPointer()))->handleHit(damage, healthdamage, shielddamage, originator);
@@ -276 +279 @@
             if (itt->second == part)
             {
-                //this->detach(itt->first);
+                this->detach(itt->first);
                 //itt->first->destroy();
-                itt->first->setActive(false);
-                itt->first->setVisible(false);
-                itt->first->setCollisionResponse(false);
+                //itt->first->setActive(false);
+                //itt->first->setVisible(false);
+                //itt->first->setCollisionResponse(false);
+                //itt->first->setCollisionType(None);
+                //itt->first->deactivatePhysics();
                 this->partMap_.erase(itt);
             }
@@ -286 +291 @@
     }
 
+    /**
+    @brief
+        Detaches a child WorldEntity from this instance.
+    */
+    void ModularSpaceShip::detach(WorldEntity* object)
+    {
+        std::set<WorldEntity*>::iterator it = this->children_.find(object);
+        if (it == this->children_.end())
+        {
+            orxout(internal_warning) << "Cannot detach an object that is not a child." << endl;
+            return;
+        }
+
+        // collision shapes
+        orxout() << "MSS: detach()" << endl;
+
+        this->printBtChildShapes((btCompoundShape*)(this->getWorldEntityCollisionShape()->getCollisionShape()), 2, 0);
+        this->detachCollisionShape(object->collisionShape_);  // after succeeding, causes a crash in the collision handling
+        this->printBtChildShapes((btCompoundShape*)(this->getWorldEntityCollisionShape()->getCollisionShape()), 2, 0);
+
+        // mass
+        if (object->getMass() > 0.0f)
+        {
+            this->childrenMass_ -= object->getMass();
+            recalculateMassProps();
+        }
+
+        this->detachNode(object->node_);
+        this->children_.erase(it);        // this causes a crash when unloading the level. Or not?
+
+        object->notifyDetached();
+        orxout() << "MSS: detach() completed." << endl;
+    }
 }

code/branches/modularships/src/orxonox/worldentities/pawns/ModularSpaceShip.h

@@ -118 +118 @@
             void removeShipPart(ShipPart* part);
 
+            void detach(WorldEntity* object);
+
             virtual void updatePartAssignment();