Changeset 9723 in orxonox.OLD

Timestamp:

Sep 7, 2006, 10:33:06 PM (18 years ago)

Author:

bensch

Message:

orxonox/trunk: safer smart-pointer

Location:

branches/new_class_id/src

Files:

• lib/graphics/text_engine/font.cc (modified) (1 diff)
• lib/util/count_pointer.h (modified) (1 diff)
• story_entities/game_world.cc (modified) (1 diff)
• world_entities/weapons/weapon.cc (modified) (2 diffs)

branches/new_class_id/src/lib/graphics/text_engine/font.cc

@@ -132 +132 @@
 
   this->registerObject(this, Font::_objectList);
-  if (Font::defaultFontData.get() == NULL)
+  if (Font::defaultFontData.isNull())
   {
     Font::initDefaultFont();

branches/new_class_id/src/lib/util/count_pointer.h

@@ -9 +9 @@
 {
 public:
-    explicit CountPointer(X* p = 0) // allocate a new counter
-        : itsCounter(0) { if (p) itsCounter = new counter(p); }
-    virtual ~CountPointer() { release(); }
-    CountPointer(const CountPointer& r) { acquire(r.itsCounter); }
-    CountPointer& operator=(const CountPointer& r)
+  explicit CountPointer(X* p = NULL) // allocate a new counter
+      : itsCounter(NULL) { if (p) itsCounter = new counter(p); }
+virtual ~CountPointer() { release(); }
+  CountPointer(const CountPointer& r) { acquire(r.itsCounter); }
+  CountPointer& operator=(const CountPointer& r)
+  {
+    if (this != &r)
     {
-        if (this != &r) {
-            release();
-            acquire(r.itsCounter);
-        }
-        return *this;
+      release();
+      acquire(r.itsCounter);
     }
-    bool operator==(const CountPointer& r) const { return this->itsCounter->ptr == r.itsCounter->ptr; };
-    X& operator*()  const { return *itsCounter->ptr; }
-    X* operator->() const { return itsCounter->ptr; }
-    X* get()        const { return itsCounter ? itsCounter->ptr : 0; }
-    bool unique()   const { return (itsCounter ? itsCounter->count == 1 : true); }
-    virtual unsigned int count() const { return (this->itsCounter ? itsCounter->count : 0); }
+    return *this;
+  }
+  bool operator==(const CountPointer& r) const { return this->itsCounter->ptr == r.itsCounter->ptr; };
+  inline X& operator*()  const { return *itsCounter->ptr; }
+  inline X* operator->() const { return itsCounter->ptr; }
+inline bool unique()   const { return (itsCounter ? itsCounter->count == 1 : true); }
+  inline bool isNull()   const { return (!itsCounter); }
+
+virtual unsigned int count() const { return (this->itsCounter ? itsCounter->count : 0); }
 private:
 
-    struct counter {
-        counter(X* p = 0, unsigned c = 1) : ptr(p), count(c) {}
-        X*          ptr;
-        unsigned    count;
-    }* itsCounter;
+  struct counter
+  {
+    counter(X* p = NULL, unsigned c = 1) : ptr(p), count(c) {}
+    X*          ptr;
+    unsigned    count;
+  }
+  * itsCounter;
 
-    void acquire(counter* c)
+  void acquire(counter* c)
+  {
+    // increment the count
+    itsCounter = c;
+    if (c) ++c->count;
+  }
+
+  void release()
+  {
+    // decrement the count, delete if it is 0
+    if (itsCounter)
     {
-      // increment the count
-        itsCounter = c;
-        if (c) ++c->count;
+      if (--itsCounter->count == 0)
+      {
+        delete itsCounter->ptr;
+        delete itsCounter;
+      }
+      itsCounter = NULL;
     }
-
-    void release()
-    {
-      // decrement the count, delete if it is 0
-        if (itsCounter) {
-            if (--itsCounter->count == 0) {
-                delete itsCounter->ptr;
-                delete itsCounter;
-            }
-            itsCounter = 0;
-        }
-    }
+  }
 };
 

branches/new_class_id/src/story_entities/game_world.cc

@@ -415 +415 @@
     if (currentFrame - this->lastFrame < .01)
     {
-      SDL_Delay(1000.0 * (0.01 - (currentFrame - lastFrame)));
+      SDL_Delay((int)1000.0 * (0.01 - (currentFrame - lastFrame)));
       currentFrame = Timer::getNow();
     }

branches/new_class_id/src/world_entities/weapons/weapon.cc

@@ -542 +542 @@
 {
   PRINTF(4)("Reloading Weapon %s\n", this->getCName());
-  if (this->ammoContainer.get() != NULL &&
+  if (!this->ammoContainer.isNull() &&
       unlikely(this->energy + this->ammoContainer->getStoredEnergy() < this->minCharge))
   {
@@ -554 +554 @@
     this->soundSource->play(this->soundBuffers[WA_RELOAD]);
 
-  if (this->ammoContainer.get() != NULL)
+  if (!this->ammoContainer.isNull())
     this->ammoContainer->fillWeapon(this);
   else