Changeset 8407

Timestamp:

May 5, 2011, 11:14:59 PM (13 years ago)

Author:

scheusso

Message:

fixing a (quite huge) network memory leak

File:

• code/trunk/src/libraries/network/GamestateManager.cc (modified) (2 diffs)

code/trunk/src/libraries/network/GamestateManager.cc

@@ -228 +228 @@
 //       packet::Gamestate* gs = new packet::Gamestate(*gamestate);
 //     packet::Gamestate* gs = gamestate;
-    packet::Gamestate *gs = new packet::Gamestate(*gamestate); //TODO: is this neccessary ?
+    packet::Gamestate *gs = new packet::Gamestate(*gamestate); //this is neccessary because the gamestate are being kept (to diff them later on) for each client seperately
 //     packet::Gamestate *gs = new packet::Gamestate();
 //     gs->collectData( id_, 0x1 );
@@ -289 +289 @@
 
 //    assert(curid==GAMESTATEID_INITIAL || curid<=gamestateID); // this line is commented out because acknowledgements are unreliable and may arrive in distorted order
-    if( gamestateID <= curid )
+    if( gamestateID <= curid && curid != GAMESTATEID_INITIAL )
         return true;
 COUT(4) << "acking gamestate " << gamestateID << " for peerID: " << peerID << " curid: " << curid << std::endl;