Changeset 8307

Timestamp:

Apr 22, 2011, 10:23:04 PM (13 years ago)

Author:

rgrieder

Message:

Manage PawnManager by Scopes. Then the singleton should get deleted in any case.

Location:

code/branches/kicklib2/src/orxonox

Files:

• PawnManager.cc (modified) (4 diffs)
• PawnManager.h (modified) (1 diff)
• worldentities/pawns/Pawn.cc (modified) (2 diffs)

code/branches/kicklib2/src/orxonox/PawnManager.cc

@@ -29 +29 @@
 #include "PawnManager.h"
 
+#include "util/ScopedSingletonManager.h"
 #include "core/CoreIncludes.h"
 #include "worldentities/pawns/Pawn.h"
@@ -34 +35 @@
 namespace orxonox
 {
-    PawnManager* PawnManager::singletonPtr_s = 0;
+    ManageScopedSingleton(PawnManager, ScopeID::Root, false);
 
     PawnManager::PawnManager()
@@ -43 +44 @@
     PawnManager::~PawnManager()
     {
+        // Be sure to delete all the pawns
+        for (ObjectList<Pawn>::iterator it = ObjectList<Pawn>::begin(); it != ObjectList<Pawn>::end(); )
+            (it++)->destroy();
     }
 
-    void PawnManager::touch()
+    void PawnManager::preUpdate(const Clock& time)
     {
-        if (!PawnManager::singletonPtr_s)
-            new PawnManager();
-    }
-
-    void PawnManager::tick(float dt)
-    {
-        unsigned int count = 0;
-        for (ObjectList<Pawn>::iterator it = ObjectList<Pawn>::begin(); it != ObjectList<Pawn>::end(); ++count)
+        for (ObjectList<Pawn>::iterator it = ObjectList<Pawn>::begin(); it != ObjectList<Pawn>::end(); )
         {
             if (!it->isAlive())
@@ -61 +58 @@
                 ++it;
         }
-
-        if (count == 0)
-            this->destroy();
     }
 }

code/branches/kicklib2/src/orxonox/PawnManager.h

@@ -37 +37 @@
 namespace orxonox
 {
-    class _OrxonoxExport PawnManager : protected Singleton<PawnManager>, public Tickable
+    class _OrxonoxExport PawnManager : public Singleton<PawnManager>, public Tickable
     {
             friend class Singleton<PawnManager>;
         public:
-            static void touch();
+            PawnManager();
+            virtual ~PawnManager();
 
-            virtual void tick(float dt);
+            virtual void preUpdate(const Clock& time);
 
         private:
-            PawnManager();
-            virtual ~PawnManager();
 
             static PawnManager* singletonPtr_s;

code/branches/kicklib2/src/orxonox/worldentities/pawns/Pawn.cc

@@ -36 +36 @@
 #include "network/NetworkFunction.h"
 
-#include "PawnManager.h"
 #include "infos/PlayerInfo.h"
 #include "controllers/Controller.h"
@@ -59 +58 @@
         RegisterObject(Pawn);
 
-        PawnManager::touch();
         this->bAlive_ = true;
         this->bReload_ = false;