Changeset 8123 in orxonox.OLD

Timestamp:

Jun 2, 2006, 6:16:15 PM (18 years ago)

Author:

bensch

Message:

gui: better outputting in the ShellBuffer

Location:

branches/gui/src/lib/shell

Files:

• shell_buffer.cc (modified) (4 diffs)
• shell_buffer.h (modified) (3 diffs)

branches/gui/src/lib/shell/shell_buffer.cc

@@ -41 +41 @@
   ShellBuffer* ShellBuffer::singletonRef = NULL;
   std::list<std::string> ShellBuffer::buffer;
+  char ShellBuffer::bufferArray[SHELL_BUFFER_SIZE];
+
 
   /**
@@ -64 +66 @@
   bool ShellBuffer::addBufferLineStatic(const char* line, ...)
   {
-    va_list arguments;
-    va_start(arguments, line);
-
     static OrxThread::Mutex ShellBuffer__bufferMutex;
 
     OrxThread::MutexLock bufferLock(&ShellBuffer__bufferMutex);
+
+    va_list arguments;
+    va_start(arguments, line);
+    vsnprintf(ShellBuffer::bufferArray, SHELL_BUFFER_SIZE, line, arguments);
+    va_end(arguments);
+
 #if DEBUG_LEVEL < 3
     if (ShellBuffer::singletonRef == NULL)
 #endif
-      vprintf(line, arguments);
+      printf(ShellBuffer::bufferArray);
 #if DEBUG_LEVEL < 3
     else
@@ -79 +84 @@
     if (ShellBuffer::singletonRef != NULL)
 #endif
-      ShellBuffer::singletonRef->addBufferLine(line, arguments);
+      ShellBuffer::singletonRef->addBufferLine(ShellBuffer::bufferArray);
     return true;
   }
@@ -91 +96 @@
    * and displays the line as the First Line of the display-buffer
    */
-  void ShellBuffer::addBufferLine(const char* line, va_list arguments)
+  void ShellBuffer::addBufferLine(const char* line)
   {
-    // copy the output to the bufferArray
-    vsprintf(this->bufferArray, line, arguments);
-
-    std::string inputBuffer = this->keepBuffer + this->bufferArray;
+    std::string inputBuffer = this->keepBuffer + line;
 
     int lineBegin = 0;

branches/gui/src/lib/shell/shell_buffer.h

@@ -33 +33 @@
 
     static bool addBufferLineStatic(const char* line, ...);
-    void addBufferLine(const char* line, va_list arg);
+    void addBufferLine(const char* line);
 
     /// BUFFER
@@ -56 +56 @@
     unsigned int                  maxBufferSize;                         //!< The Size of the buffer
 
-    char                          bufferArray[SHELL_BUFFER_SIZE];     //!< a BUFFER for fast writing
     std::string                   keepBuffer;                         //!< a BUFFER to have multi-non-newLine commands be copied into the shell.
 
@@ -62 +61 @@
 
     // The Beginning of buffer (buffer.front()) is the last added line.
+    static char                   bufferArray[SHELL_BUFFER_SIZE];     //!< a BUFFER for fast writing
     static std::list<std::string> buffer;                             //!< A list of stored char-arrays(strings) to store the history
   };