Changeset 7761 in orxonox.OLD

Timestamp:

May 22, 2006, 3:14:07 PM (18 years ago)

Author:

bensch

Message:

orxonox/trunk: ShellBuffer with STD::STRING… hope it works

Location:

trunk/src/lib/shell

Files:

• shell_buffer.cc (modified) (2 diffs)
• shell_buffer.h (modified) (2 diffs)

trunk/src/lib/shell/shell_buffer.cc

@@ -35 +35 @@
 
     this->lineCount = 0;
-    this->keepBufferArray[0] = '\0';
     this->bufferArray[0] = '\0';
-    this->keepBuffer = false;
 
     this->setBufferSize(100);
@@ -123 +121 @@
   void ShellBuffer::addBufferLine(const char* line, va_list arguments)
   {
-    char* inputEnd;
-    char* newLineBegin;
-    char* newLineEnd;
-
     // copy the output to the bufferArray
     vsprintf(this->bufferArray, line, arguments);
 
-    // check if we have something left in the buffers
-    // if so, append the new String to this one.
-    if (unlikely(this->keepBuffer))
+    std::string inputBuffer = this->keepBuffer + this->bufferArray;
+
+    int lineBegin = 0;
+    int lineEnd = 0;
+    // adding all the new Lines
+    while (lineEnd < inputBuffer.size())
     {
-      strcat(this->keepBufferArray, this->bufferArray);
-      inputEnd = this->keepBufferArray + strlen(this->bufferArray);
-      newLineBegin = this->keepBufferArray;
-      this->keepBuffer = false;
-    }
-    else
-    {
-      inputEnd = this->bufferArray + strlen(this->bufferArray);
-      newLineBegin = this->bufferArray;
-    }
+      lineBegin = lineEnd;
+      lineEnd = inputBuffer.find('\n', (lineBegin == 0) ? 0: ++lineBegin);
+      if (likely(lineEnd != std::string::npos ))
+      {
+        this->lineCount++;
 
-    // adding all the new Lines
-    while (newLineBegin < inputEnd)
-    {
-      newLineEnd = strchr(newLineBegin, '\n');
-      if (likely(newLineEnd != NULL && *newLineEnd == '\n'))
-        *newLineEnd = '\0';
-      else
+        printf("Test:: %s \n", inputBuffer.substr(lineBegin, lineEnd - lineBegin).c_str());
+        this->buffer.push_front(inputBuffer.substr(lineBegin, lineEnd - lineBegin));
+        if (likely (this->shell != NULL) && unlikely (this->shell->isActive()))
+          this->shell->printToDisplayBuffer(this->buffer.front());
+      }
+      else      // No end of Line reached.
       {
-        unsigned int len = strlen(newLineBegin);
-        char* copyBuffer = new char[len+1];
-        strcpy(copyBuffer, newLineBegin);
-        strncpy(this->keepBufferArray, copyBuffer, len);
-        delete[] copyBuffer;
-        this->keepBufferArray[len] = '\0';
-        this->keepBuffer = true;
+        this->keepBuffer = inputBuffer.substr(lineBegin, inputBuffer.size() - lineBegin);
         break;
       }
 
-      this->lineCount++;
-      this->buffer.push_front(newLineBegin);
-      if (likely (this->shell != NULL) && unlikely (this->shell->isActive()))
-        this->shell->printToDisplayBuffer(newLineBegin);
+
 
       if (this->buffer.size() > this->bufferSize)
         this->buffer.pop_back();
-
-      newLineBegin = newLineEnd+1;
     }
   }

trunk/src/lib/shell/shell_buffer.h

@@ -8 +8 @@
 #define _SHELL_BUFFER_H
 
+#include <string>
 #include <list>
 #include <stdarg.h>
@@ -61 +62 @@
     Shell*                        shell;                              //!< the Registered Shell.
     char                          bufferArray[SHELL_BUFFER_SIZE];     //!< a BUFFER for fast writing
-    char                          keepBufferArray[SHELL_BUFFER_SIZE]; //!< a BUFFER to have multi-non-newLine commands be copied into the shell.
-    bool                          keepBuffer;                         //!< if the keepbuffer contains unfinished lines.
+    std::string                   keepBuffer;                         //!< a BUFFER to have multi-non-newLine commands be copied into the shell.
 
     unsigned long                 lineCount;                          //!< how many Lines have been written out so far.