Changeset 7008 for code/branches/presentation3/src/modules/pickup

Timestamp:

May 29, 2010, 9:33:33 PM (14 years ago)

Author:

dafrick

Message:

Fixed a bug in pickups that caused the clone method of Pickup.h not to be called via SUPER.

Location:

code/branches/presentation3/src/modules/pickup

Files:

• Pickup.cc (modified) (2 diffs)
• Pickup.h (modified) (1 diff)
• items/HealthPickup.cc (modified) (2 diffs)

code/branches/presentation3/src/modules/pickup/Pickup.cc

@@ -48 +48 @@
     /*static*/ const std::string Pickup::durationTypeOnce_s = "once";
     /*static*/ const std::string Pickup::durationTypeContinuous_s = "continuous";
+
+    CreateUnloadableFactory(Pickup);
 
     Pickup::Pickup(BaseObject* creator) : BaseObject(creator)
@@ -146 +148 @@
     void Pickup::setActivationType(const std::string& type)
     {
-        if(Pickup::activationTypeImmediate_s.compare(type))
+        if(Pickup::activationTypeImmediate_s.compare(type) == 0)
         {
             this->activationType_ = pickupActivationType::immediate;
         }
-        else if(Pickup::activationTypeOnUse_s.compare(type))
+        else if(Pickup::activationTypeOnUse_s.compare(type) == 0)
         {
             this->activationType_ = pickupActivationType::onUse;

code/branches/presentation3/src/modules/pickup/Pickup.h

@@ -77 +77 @@
     {
 
-        protected:
+        public:
             Pickup(BaseObject* creator); //!< Constructor.
-
-        public:
             virtual ~Pickup(); //!< Destructor.
 

code/branches/presentation3/src/modules/pickup/items/HealthPickup.cc

@@ -189 +189 @@
     {
         SUPER(HealthPickup, changedUsed);
-        
+
         //! If the pickup is not picked up nothing must be done.
         if(!this->isPickedUp())
@@ -290 +290 @@
         if(item == NULL)
             item = new HealthPickup(this);
-        
+
         SUPER(HealthPickup, clone, item);
-        
+
         HealthPickup* pickup = dynamic_cast<HealthPickup*>(item);
         pickup->setHealth(this->getHealth());