Changeset 6203

Timestamp:

Dec 2, 2009, 4:57:24 PM (14 years ago)

Author:

rgrieder

Message:

Added buffer buffering: Sounds are only loaded into one buffer and then reused.

Location:

code/branches/presentation2/src

Files:

• libraries/core/Resource.h (modified) (1 diff)
• orxonox/sound/AmbientSound.cc (modified) (1 diff)
• orxonox/sound/BaseSound.cc (modified) (8 diffs)
• orxonox/sound/BaseSound.h (modified) (3 diffs)
• orxonox/sound/CMakeLists.txt (modified) (1 diff)
• orxonox/sound/SoundBuffer.cc (added)
• orxonox/sound/SoundBuffer.h (added)
• orxonox/sound/SoundManager.cc (modified) (2 diffs)
• orxonox/sound/SoundManager.h (modified) (4 diffs)

code/branches/presentation2/src/libraries/core/Resource.h

@@ -86 +86 @@
             bool bSearchGroupsIfNotFound = false);
 
+        //! Similar to open(string, string, bool), but with a fileInfo struct
+        static DataStreamPtr open(shared_ptr<ResourceInfo> fileInfo,
+            bool bSearchGroupsIfNotFound = false)
+        {
+            return open(fileInfo->filename, fileInfo->group, bSearchGroupsIfNotFound);
+        }
+
         /**
         @brief

code/branches/presentation2/src/orxonox/sound/AmbientSound.cc

@@ -71 +71 @@
         if (GameMode::playsSound())
         {
-            COUT(3) << "Sound: " << this->getSource() << ": Playing" << std::endl;
             SoundManager::getInstance().registerAmbientSound(this);
         }

code/branches/presentation2/src/orxonox/sound/BaseSound.cc

@@ -31 +31 @@
 #include <cassert>
 #include <vector>
-#include <AL/alut.h>
-#include <vorbis/vorbisfile.h>
+#include <al.h>
 
 #include "core/CoreIncludes.h"
@@ -38 +37 @@
 #include "core/Resource.h"
 #include "core/XMLPort.h"
+#include "SoundBuffer.h"
 #include "SoundManager.h"
 
@@ -44 +44 @@
     BaseSound::BaseSound()
         : audioSource_(0)
-        , audioBuffer_(0)
+        , volume_(1.0)
         , bLoop_(false)
         , state_(Stopped)
@@ -82 +82 @@
             alSourcePlay(this->audioSource_);
 
-            if (alGetError() != AL_NO_ERROR)
-                 COUT(2) << "Sound: OpenAL: Error playing sound " << this->audioSource_ << std::endl;
+            if (int error = alGetError())
+                COUT(2) << "Sound: Error playing sound: " << error << std::endl;
         }
     }
@@ -155 +155 @@
         }
 
-        if (this->audioBuffer_ != 0 && alIsBuffer(this->audioBuffer_))
+        if (this->soundBuffer_ != NULL)
         {
             alSourceStop(this->audioSource_);
             // Unload old sound first
             alSourcei(this->audioSource_, AL_BUFFER, 0);
-            alDeleteBuffers(1, &this->audioBuffer_);
-            this->audioBuffer_ = 0;
+            this->soundBuffer_.reset();
         }
 
@@ -168 +167 @@
             return;
 
-        COUT(3) << "Sound: OpenAL ALUT: loading file " << source << std::endl;
         // Get DataStream from the resources
         shared_ptr<ResourceInfo> fileInfo = Resource::getInfo(source);
@@ -176 +174 @@
             return;
         }
-        dataStream_ = Resource::open(source);
-        // Read everything into a temporary buffer
-        char* buffer = new char[fileInfo->size];
-        dataStream_->read(buffer, fileInfo->size);
-        dataStream_->seek(0);
-
-        this->audioBuffer_ = alutCreateBufferFromFileImage(buffer, fileInfo->size);
-        delete[] buffer;
-
-        if (this->audioBuffer_ == AL_NONE)
-        {
-            COUT(2) << "Sound: OpenAL ALUT: " << alutGetErrorString(alutGetError()) << std::endl;
-            if (source.find("ogg", 0) != std::string::npos)
-            {
-                COUT(2) << "Sound: Trying fallback ogg loader" << std::endl;
-                this->audioBuffer_ = this->loadOggFile();
-            }
-
-            if (this->audioBuffer_ == AL_NONE)
-            {
-                COUT(2) << "Sound: fallback ogg loader failed: " << alutGetErrorString(alutGetError()) << std::endl;
-                return;
-            }
-        }
-
-        alSourcei(this->audioSource_, AL_BUFFER, this->audioBuffer_);
+
+        this->soundBuffer_ = SoundManager::getInstance().getSoundBuffer(fileInfo);
+        if (this->soundBuffer_ == NULL)
+            return;
+
+        alSourcei(this->audioSource_, AL_BUFFER, this->soundBuffer_->getBuffer());
         if (alGetError() != AL_NO_ERROR)
         {
@@ -217 +195 @@
             alSourcePause(this->audioSource_);
 
-        if (alGetError() != AL_NO_ERROR)
-            COUT(2) << "Sound: OpenAL: Error playing sound " << this->audioSource_ << std::endl;
-    }
-
-    size_t readVorbis(void* ptr, size_t size, size_t nmemb, void* datasource)
-    {
-        return static_cast<Ogre::DataStream*>(datasource)->read(ptr, size * nmemb);
-    }
-
-    int seekVorbis(void* datasource, ogg_int64_t offset, int whence)
-    {
-        Ogre::DataStream* stream = static_cast<Ogre::DataStream*>(datasource);
-        int offset_beg = offset;
-        if (whence == SEEK_CUR)
-            offset_beg = stream->tell() + offset;
-        else if (whence == SEEK_END)
-            offset_beg = stream->size() + offset;
-        else if (whence != SEEK_SET)
-            return -1;
-        stream->seek(offset_beg);
-        return 0;
-    }
-
-    long tellVorbis(void* datasource)
-    {
-        return static_cast<long>(static_cast<Ogre::DataStream*>(datasource)->tell());
-    }
-
-    ALuint BaseSound::loadOggFile()
-    {
-        char inbuffer[256*1024];
-        std::vector<char> outbuffer;
-        outbuffer.reserve(80*1024*1024);
-        OggVorbis_File vf;
-        vorbis_info* vorbisInfo;
-        int eof = false;
-        int current_section;
-        ALuint buffer;
-        ALenum format;
-
-        // Open file with custom streaming
-        ov_callbacks vorbisCallbacks;
-        vorbisCallbacks.read_func  = &readVorbis;
-        vorbisCallbacks.seek_func  = &seekVorbis;
-        vorbisCallbacks.tell_func  = &tellVorbis;
-        vorbisCallbacks.close_func = NULL;
-
-        int ret = ov_open_callbacks(dataStream_.get(), &vf, NULL, 0, vorbisCallbacks);
-        if (ret < 0)
-        {
-            COUT(2) << "Sound: libvorbisfile: File does not seem to be an Ogg Vorbis bitstream" << std::endl;
-            ov_clear(&vf);
-            return AL_NONE;
-        }
-
-        while (!eof)
-        {
-            long ret = ov_read(&vf, inbuffer, sizeof(inbuffer), 0, 2, 1, &current_section);
-            if (ret == 0)
-            {
-                eof = true;
-            }
-            else if (ret < 0)
-            {
-                COUT(2) << "Sound: libvorbisfile: error reading the file" << std::endl;
-                ov_clear(&vf);
-                return AL_NONE;
-            }
-            else
-            {
-                outbuffer.insert(outbuffer.end(), inbuffer, inbuffer + ret);
-            }
-        }
-
-        vorbisInfo = ov_info(&vf, -1);
-        if (vorbisInfo->channels == 1)
-            format = AL_FORMAT_MONO16;
-        else
-            format = AL_FORMAT_STEREO16;
-
-        alGenBuffers(1, &buffer);
-        alBufferData(buffer, format, &outbuffer[0], outbuffer.size(), vorbisInfo->rate);
-        ov_clear(&vf);
-
-        return buffer;
+        if (int error = alGetError())
+            COUT(2) << "Sound: OpenAL: Error playing sound: " << error << std::endl;
     }
 }

code/branches/presentation2/src/orxonox/sound/BaseSound.h

@@ -33 +33 @@
 
 #include <string>
+#include <boost/shared_ptr.hpp>
 #include <OgreDataStream.h>
 #include "core/OrxonoxClass.h"
@@ -38 +39 @@
 namespace orxonox
 {
+    // forward declaration
+    class SoundBuffer;
+
     /**
      * The BaseSound class is the base class for all sound file loader classes.
@@ -83 +87 @@
 
         ALuint audioSource_;
-        ALuint audioBuffer_;
+        shared_ptr<SoundBuffer> soundBuffer_;
 
     private:

code/branches/presentation2/src/orxonox/sound/CMakeLists.txt

@@ -2 +2 @@
     AmbientSound.cc
     BaseSound.cc
+    SoundBuffer.cc
     SoundManager.cc
     WorldSound.cc

code/branches/presentation2/src/orxonox/sound/SoundManager.cc

@@ -38 +38 @@
 #include "util/StringUtils.h"
 #include "util/Clock.h"
+#include "core/ConfigValueIncludes.h"
 #include "core/GameMode.h"
 #include "core/ScopedSingletonManager.h"
-#include "core/ConfigValueIncludes.h"
+#include "core/Resource.h"
+#include "SoundBuffer.h"
 #include "BaseSound.h"
 #include "AmbientSound.h"
@@ -473 +475 @@
         }
     }
+
+    shared_ptr<SoundBuffer> SoundManager::getSoundBuffer(shared_ptr<ResourceInfo> fileInfo)
+    {
+        std::map<std::string, weak_ptr<SoundBuffer> >::const_iterator it
+            = this->soundBuffers_.find(fileInfo->group + '/' + fileInfo->filename);
+        if (it != this->soundBuffers_.end())
+            return it->second.lock();
+        else
+        {
+            shared_ptr<SoundBuffer> buffer(new SoundBuffer(fileInfo));
+            this->soundBuffers_[fileInfo->group + '/' + fileInfo->filename] = buffer;
+            return buffer;
+        }
+    }
+
+    void SoundManager::removeBuffer(shared_ptr<ResourceInfo> fileInfo)
+    {
+        std::map<std::string, weak_ptr<SoundBuffer> >::const_iterator it
+            = this->soundBuffers_.find(fileInfo->group + '/' + fileInfo->filename);
+        if (it == this->soundBuffers_.end())
+            this->soundBuffers_.erase(it);
+    }
 }

code/branches/presentation2/src/orxonox/sound/SoundManager.h

@@ -33 +33 @@
 
 #include <list>
+#include <map>
 #include <string>
-#include <map>
+#include <boost/weak_ptr.hpp>
+
 #include "util/Singleton.h"
 #include "core/OrxonoxClass.h"
@@ -41 +43 @@
 namespace orxonox
 {
+    // forward declaration
+    class SoundBuffer;
     
     //! Enum for the sound type.
@@ -86 +90 @@
         bool getMute(SoundType::Value type); // tolua_export
 
+        shared_ptr<SoundBuffer> getSoundBuffer(shared_ptr<ResourceInfo> fileInfo);
+        void removeBuffer(shared_ptr<ResourceInfo> fileInfo);
+
     private:
         void processCrossFading(float dt);
@@ -118 +125 @@
         float effectsVolume_;
         std::map<SoundType::Value, bool> mute_;
+
+        std::map<std::string, weak_ptr<SoundBuffer> > soundBuffers_;
         
         static SoundManager* singletonPtr_s;