Changeset 6025 in orxonox.OLD

Timestamp:

Dec 10, 2005, 9:07:46 PM (18 years ago)

Author:

rennerc

Message:

fixed some bugs

Location:

branches/network/src

Files:

• lib/network/network_socket.cc (modified) (6 diffs)
• lib/network/network_socket.h (modified) (3 diffs)
• lib/network/network_stream.cc (modified) (6 diffs)
• subprojects/network/network_unit_test.cc (modified) (1 diff)

branches/network/src/lib/network/network_socket.cc

@@ -28 +28 @@
 #include "debug.h"
 
+static SDL_mutex* threadTerminationMutex = SDL_CreateMutex();
 
 /**
@@ -65 +66 @@
   outgoingBufferLength = 0;
 
+#ifdef _USE_OUTGOING_BUFFER
+  thread_write_running = false;
+#endif
+  thread_read_running = false;
+
   incomingBufferMutex = SDL_CreateMutex();
   outgoingBufferMutex = SDL_CreateMutex();
+
+
   socketMutex = SDL_CreateMutex();
   terminateThread = false;
@@ -89 +97 @@
  * Default destructor
  */
-NetworkSocket::~ NetworkSocket( )
-{
+NetworkSocket::~NetworkSocket( )
+{
+  this->terminateThread = true;
   /* Quit SDL_net */
   // NOTE: what if other instances of NetworkSocket running?
@@ -275 +284 @@
     if (nbytesread<=0)
     {
-      printf("SDLNet_TCP_Recv: %s\n", SDLNet_GetError());
+      if (nbytesread<0)
+        printf("SDLNet_TCP_Recv: %s\n", SDLNet_GetError());
 
       SDL_mutexP(self->socketMutex);
@@ -295 +305 @@
   }
 
+  SDL_mutexP(threadTerminationMutex);
+  self->thread_read_running = false;
+
+  if ( !self->thread_write_running )
+    delete self;
+  SDL_mutexV(threadTerminationMutex);
+
+  printf("QUIT READ THREAD\n");
   return 0;
 }
@@ -347 +365 @@
   }
 
+  SDL_mutexP(threadTerminationMutex);
+  self->thread_write_running = false;
+
+  if ( !self->thread_read_running )
+    delete self;
+  SDL_mutexV(threadTerminationMutex);
+
   printf("QUIT WRITE THREAD\n");
   return 0;

branches/network/src/lib/network/network_socket.h

@@ -63 +63 @@
   bool terminateThread;
 
+  static SDL_mutex* threadTerminationMutex;
   static int thread_read(void * data);
+  bool thread_read_running;
 #ifdef _USE_OUTGOING_BUFFER
   static int thread_write(void * data);
+  bool thread_write_running;
 #endif
 
@@ -74 +77 @@
   void init();
 
+  //dont make this public use destroy() instead
+  ~NetworkSocket();
+
 public:
 
@@ -79 +85 @@
   NetworkSocket(IPaddress ip);
   NetworkSocket(TCPsocket sock);
-  ~NetworkSocket();
+  void destroy() { terminateThread = true; };
+
 
   void connectToServer(IPaddress ip);

branches/network/src/lib/network/network_stream.cc

@@ -93 +93 @@
     {
       (*i)->disconnectServer();
-      delete *i;
+      (*i)->destroy();
     }
   }
@@ -113 +113 @@
 void NetworkStream::processData()
 {
-  printf("processData()");
+  //PRINTF(0)("processData()\n");
   if ( this->type == NET_SERVER )
     this->updateConnectionList();
@@ -188 +188 @@
 {
   //check for new connections
+
   NetworkSocket* tempNetworkSocket = serverSocket->getNewSocket();
 
@@ -200 +201 @@
     } else
     {
+      clientId = networkSockets.size();
       networkSockets.push_back(tempNetworkSocket);
-      clientId = networkSockets.size();
-    }
-
-    PRINTF(0)("New Client: %s", clientId);
+    }
+
+    PRINTF(0)("New Client: %d\n", clientId);
     //TODO: start handshake
     //new Handshake(true, clientId);
@@ -216 +217 @@
     {
       //TODO: tell EntityManager that this player left the game
-
-      delete networkSockets[i];
+      PRINTF(0)("Client is gone: %d\n", i);
+
+      //delete networkSockets[i];
+      networkSockets[i]->destroy();
       networkSockets[i] = NULL;
 
@@ -231 +234 @@
   }
 
-}
+
+}

branches/network/src/subprojects/network/network_unit_test.cc

@@ -196 +196 @@
   {
     netMan->synchronize();
-    SDL_Delay(500);
+    SDL_Delay(1000);
   }