Changeset 3880 in orxonox.OLD

Timestamp:

Apr 18, 2005, 7:29:43 PM (19 years ago)

Author:

bensch

Message:

orxonox/trunk: trackManager should not end up in a seg-fault anymore when findByID returns NULL

File:

• orxonox/trunk/src/track_manager.cc (modified) (3 diffs)

orxonox/trunk/src/track_manager.cc

@@ -762 +762 @@
 {
   TrackElement* tmpTrackElem;
+  TrackElement* tmpJoinElem;
   for (int i = 0; i < count; i++)
     if (!this->firstTrackElem->findByID(trackIDs[i]))
@@ -793 +794 @@
   for (int i = 0; i < count; i++)
     {
-      TrackElement* tmpJoinElem = this->firstTrackElem->findByID(trackIDs[i]);
-      if (tmpJoinElem->childCount == 0
-          && tmpJoinElem->endTime > tmpLatestTime)
-        tmpLatestTime = tmpJoinElem->endTime;
+      if(tmpJoinElem = this->firstTrackElem->findByID(trackIDs[i]))
+        {
+          if (tmpJoinElem->childCount == 0
+              && tmpJoinElem->endTime > tmpLatestTime)
+            tmpLatestTime = tmpJoinElem->endTime;
+        }
     }
   // time the main Join.
@@ -804 +807 @@
   for (int i = 1; i < count; i++)
     {
-      TrackElement* tmpJoinElem = this->firstTrackElem->findByID(trackIDs[i]);
-      if (tmpJoinElem->childCount > 0)
-        printf("!!This Curve has children, and as such will not be joined!!\n You can try joining other childless TrackElements to this one!");
-      else
-        {
-          this->addPoint(tmpc2Point, tmpJoinElem);
-          this->addPoint(tmpTangentPoint, tmpJoinElem);
-          this->addPoint(tmpEndPoint, tmpJoinElem);
-          // time all other Joins
-          tmpJoinElem->jumpTime = tmpLatestTime - tmpJoinElem->endTime;
-          
-          //Copying Joint-Info
-          tmpJoinElem->children = firstJoint->children;
-          tmpJoinElem->childCount = firstJoint->childCount;
-          tmpJoinElem->isSavePoint = firstJoint->isSavePoint;
-          tmpJoinElem->isFork = firstJoint->isFork;
-
-          tmpJoinElem->isJoined = true;
+      if( tmpJoinElem = this->firstTrackElem->findByID(trackIDs[i]))
+        {
+          if (tmpJoinElem->childCount > 0)
+            printf("!!This Curve has children, and as such will not be joined!!\n You can try joining other childless TrackElements to this one!");
+          else
+            {
+              this->addPoint(tmpc2Point, tmpJoinElem);
+              this->addPoint(tmpTangentPoint, tmpJoinElem);
+              this->addPoint(tmpEndPoint, tmpJoinElem);
+              // time all other Joins
+              tmpJoinElem->jumpTime = tmpLatestTime - tmpJoinElem->endTime;
+              
+              //Copying Joint-Info
+              tmpJoinElem->children = firstJoint->children;
+              tmpJoinElem->childCount = firstJoint->childCount;
+              tmpJoinElem->isSavePoint = firstJoint->isSavePoint;
+              tmpJoinElem->isFork = firstJoint->isFork;
+              
+              tmpJoinElem->isJoined = true;
+            }
         }
     }