Changeset 1653 for code/branches/gui/src/core

Timestamp:

Aug 5, 2008, 9:50:26 PM (16 years ago)

Author:

rgrieder

Message:

• getInstance is probably more suitable than getSingleton (as x3n has already done so in most of his classes) I changed it in Orxonox and GraphicsEngine. Maybe more to come.
• Removed derivation from BaseObject in InputState (templates work well too, don't need a factory at all)

Location:

code/branches/gui/src/core/input

Files:

• ExtendedInputState.cc (modified) (1 diff)
• ExtendedInputState.h (modified) (2 diffs)
• InputManager.cc (modified) (2 diffs)
• InputManager.h (modified) (1 diff)
• InputState.h (modified) (2 diffs)
• KeyDetector.cc (modified) (1 diff)
• SimpleInputState.cc (modified) (2 diffs)
• SimpleInputState.h (modified) (1 diff)

code/branches/gui/src/core/input/ExtendedInputState.cc

@@ -37 +37 @@
 #include <assert.h>
 #include "core/Debug.h"
-#include "core/CoreIncludes.h"
 
 namespace orxonox
 {
-    CreateFactory(ExtendedInputState);
-
     using namespace InputDevice;
-
-    ExtendedInputState::ExtendedInputState()
-    {
-        RegisterObject(ExtendedInputState);
-    }
 
     void ExtendedInputState::numberOfJoySticksChanged(unsigned int n)

code/branches/gui/src/core/input/ExtendedInputState.h

@@ -48 +48 @@
     {
         friend class InputManager;
-        friend class ClassFactory<ExtendedInputState>;
 
     public:
@@ -68 +67 @@
 
     private:
-        ExtendedInputState();
+        ExtendedInputState() { }
         ~ExtendedInputState() { }
 

code/branches/gui/src/core/input/InputManager.cc

@@ -161 +161 @@
             setConfigValues();
 
-            stateEmpty_ = createSimpleInputState("empty", -1);
+            stateEmpty_ = createInputState<SimpleInputState>("empty", -1);
             stateEmpty_->setHandler(new EmptyHandler());
             activeStates_[stateEmpty_->getPriority()] = stateEmpty_;
 
-            stateDetector_ = createSimpleInputState("detector", 101);
+            stateDetector_ = createInputState<SimpleInputState>("detector", 101);
             KeyDetector* temp = new KeyDetector();
             temp->loadBindings("storeKeyStroke");
             stateDetector_->setHandler(temp);
 
-            stateCalibrator_ = createSimpleInputState("calibrator", 100);
+            stateCalibrator_ = createInputState<SimpleInputState>("calibrator", 100);
             stateCalibrator_->setHandler(new EmptyHandler());
             InputBuffer* buffer = new InputBuffer();
@@ -1037 +1037 @@
     /**
     @brief
-        Returns a new SimpleInputState and configures it first.
-    */
-    SimpleInputState* InputManager::createSimpleInputState(const std::string &name, int priority)
-    {
-        SimpleInputState* state = new SimpleInputState();
-        if (_configureInputState(state, name, priority))
-            return state;
-        else
-        {
-            delete state;
-            return 0;
-        }
-    }
-
-    /**
-    @brief
-        Returns a new ExtendedInputState and configures it first.
-    */
-    ExtendedInputState* InputManager::createExtendedInputState(const std::string &name, int priority)
-    {
-        ExtendedInputState* state = new ExtendedInputState();
-        if (_configureInputState(state, name, priority))
-            return state;
-        else
-        {
-            delete state;
-            return 0;
-        }
-    }
-
-    /**
-    @brief
-        Returns a new InputState of type 'type' and configures it first.
-    @param type
-        String name of the class (used by the factory)
-    */
-    InputState* InputManager::createInputState(const std::string& type, const std::string &name, int priority)
-    {
-        InputState* state = dynamic_cast<InputState*>(Factory::getIdentifier(type)->fabricate());
-        if (_configureInputState(state, name, priority))
-            return state;
-        else
-        {
-            delete state;
-            return 0;
-        }
-    }
-
-    /**
-    @brief
         Removes an input state internally.
     @param name

code/branches/gui/src/core/input/InputManager.h

@@ -102 +102 @@
         void setWindowExtents(const int width, const int height);
 
-        SimpleInputState*   createSimpleInputState  (const std::string& name, int priority);
-        ExtendedInputState* createExtendedInputState(const std::string& name, int priority);
-        InputState*         createInputState(const std::string& type, const std::string &name, int priority);
+        template <class T>
+        T* createInputState(const std::string& name, int priority)
+        {
+            T* state = new T;
+            if (_configureInputState(state, name, priority))
+                return state;
+            else
+            {
+                delete state;
+                return 0;
+            }
+        }
+
         bool destroyState          (const std::string& name);
         InputState* getState       (const std::string& name);

code/branches/gui/src/core/input/InputState.h

@@ -40 +40 @@
 #include <vector>
 #include "core/Executor.h"
-#include "core/BaseObject.h"
-#include "core/CoreIncludes.h"
 #include "InputInterfaces.h"
 
 namespace orxonox
 {
-    class _CoreExport InputState : public BaseObject
+    class _CoreExport InputState
     {
         friend class InputManager;
@@ -89 +87 @@
 
     protected:
-        InputState() : priority_(0), executorOnEnter_(0), executorOnLeave_(0)
-        { RegisterObject(InputState); }
+        InputState() : priority_(0), executorOnEnter_(0), executorOnLeave_(0) { }
         virtual ~InputState() { }
 

code/branches/gui/src/core/input/KeyDetector.cc

@@ -68 +68 @@
     void KeyDetector::loadBindings(const std::string& command)
     {
+        this->command_ = command;
         clearBindings();
         setConfigValues();
-        this->command_ = command;
     }
 

code/branches/gui/src/core/input/SimpleInputState.cc

@@ -38 +38 @@
 #include "core/Debug.h"
 #include "core/Executor.h"
-#include "core/CoreIncludes.h"
 
 namespace orxonox
 {
-    CreateFactory(SimpleInputState);
-
     using namespace InputDevice;
 
@@ -51 +48 @@
         , joyStickHandlerAll_(0)
     {
-        RegisterObject(SimpleInputState);
     }
 

code/branches/gui/src/core/input/SimpleInputState.h

@@ -46 +46 @@
     {
         friend class InputManager;
-        friend class ClassFactory<SimpleInputState>;
 
     public: