Changeset 10990 for code/branches/cpp11_v2/src/libraries/core/command

Timestamp:

Dec 29, 2015, 4:47:42 PM (9 years ago)

Author:

landauf

Message:

use '= delete' to explicitly delete unimplemented copy-constructors (for non-copyable classes).
use '= default' to explicitly implement default constructors/destructors.

Location:

code/branches/cpp11_v2/src/libraries/core/command

Files:

• CommandExecutor.h (modified) (1 diff)
• Executor.cc (modified) (1 diff)
• Executor.h (modified) (1 diff)
• Functor.h (modified) (1 diff)
• IRC.h (modified) (1 diff)
• Shell.h (modified) (2 diffs)
• TclBind.h (modified) (1 diff)

code/branches/cpp11_v2/src/libraries/core/command/CommandExecutor.h

@@ -132 +132 @@
 
         private:
-            CommandExecutor() {}                            ///< Empty constructor
-            CommandExecutor(const CommandExecutor& other);  ///< Not implemented copy-constructor
-            ~CommandExecutor() {}                           ///< Empty destructor
+            CommandExecutor() = default;                      ///< Empty constructor
+            CommandExecutor(const CommandExecutor&) = delete; ///< Not implemented copy-constructor
+            ~CommandExecutor() = default;                     ///< Empty destructor
 
             static CommandExecutor& getInstance();

code/branches/cpp11_v2/src/libraries/core/command/Executor.cc

@@ -64 +64 @@
             defaultValue_[i] = other.defaultValue_[i];
         this->functor_ = other.functor_->clone();
-    }
-
-    /**
-        @brief Destructor
-    */
-    Executor::~Executor()
-    {
     }
 

code/branches/cpp11_v2/src/libraries/core/command/Executor.h

@@ -100 +100 @@
             Executor(const FunctorPtr& functor, const std::string& name = "");
             Executor(const Executor& other);
-            virtual ~Executor();
+            virtual ~Executor() = default;
 
             /// Calls the wrapped function with 0 arguments. If the function needs more arguments, the executor's default values are used.

code/branches/cpp11_v2/src/libraries/core/command/Functor.h

@@ -187 +187 @@
 
         public:
-            virtual ~Functor() {}
+            virtual ~Functor() = default;
 
             /// Calls the function-pointer with up to five arguments. In case of a member-function, the assigned object-pointer is used to call the function. @return Returns the return-value of the function (if any; MultiType::Null otherwise)

code/branches/cpp11_v2/src/libraries/core/command/IRC.h

@@ -65 +65 @@
 
             IRC();
-            IRC(const IRC& other);              ///< Copy-constructor: Not implemented
-            ~IRC() {}                           ///< Destructor
+            IRC(const IRC&) = delete;
+            ~IRC() = default;
 
             Tcl::interpreter* interpreter_;     ///< The Tcl interpreter that is used for the IRC connection

code/branches/cpp11_v2/src/libraries/core/command/Shell.h

@@ -61 +61 @@
 
         public:
-            virtual ~ShellListener() {}
+            ShellListener() = default;
+            virtual ~ShellListener() = default;
 
         private:
@@ -148 +149 @@
 
         private:
-            Shell(const Shell& other);
+            Shell(const Shell&) = delete;
 
             // DevModeListener

code/branches/cpp11_v2/src/libraries/core/command/TclBind.h

@@ -124 +124 @@
 
         private:
-            TclBind(const TclBind& other);      ///< Copy-constructor, not implemented
+            TclBind(const TclBind&) = delete;
 
             static std::string tcl_helper(Tcl::object const &args, bool bQuery);