Changeset 2239

Timestamp:

Nov 20, 2008, 10:13:11 PM (15 years ago)

Author:

rgrieder

Message:

Resolved tolua include directory problem in another fashion by adding CMAKE_BINARY_DIR/src to the include directories and adjusting the the include directives. There were some changes necessary in package.lua (it uses the package name as folder to write "#include "core/CommandExecutor.h"").

The problem with the old resolution (-iquotes) was that you could write "#include "Core.h"" in a file that is not in the core, because src/core was effectively added to the list of include directories (just the ones with quotes of course).

Location:

code/branches/buildsystem

Files:

• cmake/UseTolua.cmake (modified) (2 diffs)
• src/CMakeLists.txt (modified) (1 diff)
• src/core/CMakeLists.txt (modified) (1 diff)
• src/core/Script.cc (modified) (1 diff)
• src/orxonox/CMakeLists.txt (modified) (1 diff)
• src/orxonox/gui/GUIManager.cc (modified) (1 diff)
• src/tolua/lua/package.lua (modified) (3 diffs)

code/branches/buildsystem/cmake/UseTolua.cmake

@@ -19 +19 @@
 GET_TARGET_PROPERTY(TOLUA_EXECUTABLE "${_tolua_executable_name}" LOCATION)
 
-MACRO(INCLUDE_DIRECTORIES_QUOTES)
-  FOREACH(_tolua_quote_dir ${ARGN})
-    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -iquote ${_tolua_quote_dir}")
-    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -iquote ${_tolua_quote_dir}")
-  ENDFOREACH(_tolua_quote_dir)
-ENDMACRO(INCLUDE_DIRECTORIES_QUOTES)
-
 MACRO(TOLUA _tolua_package _tolua_srcfiles_varname)
   # TODO: cleaner arguments handling
@@ -32 +25 @@
 
   SET(_tolua_pkgfile "${CMAKE_CURRENT_BINARY_DIR}/tolua.pkg")
-  SET(_tolua_cxxfile "${CMAKE_CURRENT_BINARY_DIR}/tolua_bind.cc")
-  SET(_tolua_hfile   "${CMAKE_CURRENT_BINARY_DIR}/tolua_bind.h")
+  SET(_tolua_cxxfile "${CMAKE_CURRENT_BINARY_DIR}/ToluaBind${_tolua_package}.cc")
+  SET(_tolua_hfile   "${CMAKE_CURRENT_BINARY_DIR}/ToluaBind${_tolua_package}.h")
   SET(${_tolua_srcfiles_varname} ${${_tolua_srcfiles_varname}} "${_tolua_cxxfile}")
 

code/branches/buildsystem/src/CMakeLists.txt

@@ -21 +21 @@
   orxonox
   tolua
+  # Required for tolua bind files that are in the build folder
+  ${CMAKE_CURRENT_BINARY_DIR}
 )
 

code/branches/buildsystem/src/core/CMakeLists.txt

@@ -54 +54 @@
 INCLUDE(UseTolua)
 TOLUA(Core CORE_SRC_FILES INPUTFILES Script.h CommandExecutor.h)
-INCLUDE_DIRECTORIES_QUOTES(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
 
 ADD_LIBRARY(core SHARED ${CORE_SRC_FILES})

code/branches/buildsystem/src/core/Script.cc

@@ -40 +40 @@
 
 #include "tolua++.h"
-#include "tolua_bind.h"
+#include "core/ToluaBindCore.h"
 
 namespace orxonox

code/branches/buildsystem/src/orxonox/CMakeLists.txt

@@ -66 +66 @@
 INCLUDE(UseTolua)
 TOLUA(Orxonox ORXONOX_SRC_FILES INPUTFILES gui/GUIManager.h)
-INCLUDE_DIRECTORIES_QUOTES(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
-INCLUDE_DIRECTORIES_QUOTES("${CMAKE_SOURCE_DIR}/src/core" "${CMAKE_BINARY_DIR}/src/core")
 
 ADD_EXECUTABLE( orxonox ${ORXONOX_SRC_FILES} )

code/branches/buildsystem/src/orxonox/gui/GUIManager.cc

@@ -43 +43 @@
 #include "core/input/InputManager.h"
 #include "core/input/SimpleInputState.h"
-#include "../core/tolua_bind.h"
 #include "core/ConsoleCommand.h"
 #include "core/Core.h"
-#include "tolua_bind.h"
+#include "core/ToluaBindCore.h"
+#include "orxonox/ToluaBindOrxonox.h"
 #include "GraphicsEngine.h"
 #include "OgreCEGUIRenderer.h"

code/branches/buildsystem/src/tolua/lua/package.lua

@@ -128 +128 @@
     if flags.H then
         local header = gsub(flags.H, '^.-([%w_]*%.[%w_]*)$', '%1')
-        output('#include "'..header..'"\n')
+        local package_lower = string.lower(self.name)
+        output('#include "'..package_lower..'/'..header..'"\n')
     end
 
@@ -203 +204 @@
 
     if flags.H then
-        output('#include "'..self.name..'Prereqs.h"\n')
+        local package_lower = string.lower(self.name)
+        output('#include "'..package_lower..'/'..self.name..'Prereqs.h"\n')
         output('/* Exported function */')
         output('_'..self.name..'Export')
@@ -220 +222 @@
 -- *** Thanks to Ariel Manzur for fixing bugs in nested directives ***
 function extract_code(fn,s)
-    local code = '\n$#include "'..fn..'"\n'
+    local code = '\n$#include "'..string.lower(flags.n)..'/'..fn..'"\n'
     s= "\n" .. s .. "\n" -- add blank lines as sentinels