Changeset 8615

Timestamp:

May 26, 2011, 6:01:34 PM (13 years ago)

Author:

landauf

Message:

turns out the mod(x,y) function was fucked up all the time. we need unit tests! also there was a small bug in the shell history. fixed both.

Location:

code/branches/presentation/src/libraries

Files:

• core/command/Shell.cc (modified) (1 diff)
• util/Math.h (modified) (1 diff)

code/branches/presentation/src/libraries/core/command/Shell.cc

@@ -265 +265 @@
             return;
 
-        size_t previous_offset = mod(this->historyOffset_ - 1, this->maxHistoryLength_);
+        size_t previous_offset = mod(static_cast<int>(this->historyOffset_) - 1, this->maxHistoryLength_);
         if (previous_offset < this->commandHistory_.size() && command == this->commandHistory_[previous_offset])
             return;

code/branches/presentation/src/libraries/util/Math.h

@@ -174 +174 @@
             return (x % max);
         else
-            return ((x % max) + max);
+        {
+            T temp = x % max;
+            return (temp < 0) ? (temp + max) : temp;
+        }
     }